tmaq
/
tornavis
1
0
Fork 0
Code Issues 2 Pull Requests 29 Packages Projects 24 Releases Wiki Activity
tornavis/.clang-tidy

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

54 lines
1.7 KiB
Plaintext
Raw Normal View History

Cleanup: Clang-Tidy, describe current status of rules No functional changes.
2020-09-04 14:44:31 +02:00
# The warnings below are disabled because they are too pedantic and not worth fixing.
# Some of them will be enabled as part of the Clang-Tidy task, see T78535.
Fix: Comments in clang-tidy checks list is not allowed Clang-tidy will not parse any options after the comment.
2022-05-06 14:41:58 +02:00
# NOTE: No comments in the list below is allowed. Clang-tidy will ignore items after comments in the lists flag list.
# This is because the comment is not a valid list item and it will stop parsing flags if a list item is a comment.
Initial support of clang-tidy toolchain Clang Tidy is a Clang based "linter" tool which goal is to help fixing typical programming errors. It is run as a separate compile step of every file, which slows compilation down but allows to fully analyze the file the same way as compiler does and catch non-trivial bugprone cases. This change includes: - CMake option called `WITH_CLANG_TIDY` which enables Clang Tidy linter tool on all source in the `source/` directory. This option is only available on Linux, as it is currently the easiest platform to get the Clang Tidy toolchain to work. - CMake module which is aimed to find latest available Clang Tidy. - Set of rules which allows to have Blender fully compiled without extra issues. The goal of this change is to provide a base ground so that solving all the warnings can happen later on, as a team effort. It should be possible to use Clang Tidy side-by-side with both GCC and Clang, but there seems to be some tweaks to be done in CMake to make it really work for Blender. For now use Clang toolchain if there are issues with GCC+Clang Tidy. It will be worked on in the nearest future to bring seamless experience for all configurations. Currently there is no official way of getting Clang Tidy on macOS, and on Windows there are some difficulties of hooking up Clang Tidy from LLVM package to the MSVC compiler toolchain. The actual warnings in the code will be addressed as a part of the Code Quality Days, task T78535. Differential Revision: https://developer.blender.org/D7937
2020-06-05 11:37:49 +02:00
Checks: >
-*,
readability-*,
-readability-uppercase-literal-suffix,
-readability-magic-numbers,
-readability-isolate-declaration,
-readability-convert-member-functions-to-static,
-readability-implicit-bool-conversion,
-readability-avoid-const-params-in-decls,
-readability-simplify-boolean-expr,
-readability-make-member-function-const,
Clang Tidy: ignore some passes that changed or were added in version 13 I get hundreds of clang-tidy errors without ignoring those passes right now. To not forget about the passes, I added them to T78535.
2021-11-23 19:45:05 +01:00
-readability-suspicious-call-argument,
-readability-redundant-member-init,
Initial support of clang-tidy toolchain Clang Tidy is a Clang based "linter" tool which goal is to help fixing typical programming errors. It is run as a separate compile step of every file, which slows compilation down but allows to fully analyze the file the same way as compiler does and catch non-trivial bugprone cases. This change includes: - CMake option called `WITH_CLANG_TIDY` which enables Clang Tidy linter tool on all source in the `source/` directory. This option is only available on Linux, as it is currently the easiest platform to get the Clang Tidy toolchain to work. - CMake module which is aimed to find latest available Clang Tidy. - Set of rules which allows to have Blender fully compiled without extra issues. The goal of this change is to provide a base ground so that solving all the warnings can happen later on, as a team effort. It should be possible to use Clang Tidy side-by-side with both GCC and Clang, but there seems to be some tweaks to be done in CMake to make it really work for Blender. For now use Clang toolchain if there are issues with GCC+Clang Tidy. It will be worked on in the nearest future to bring seamless experience for all configurations. Currently there is no official way of getting Clang Tidy on macOS, and on Windows there are some difficulties of hooking up Clang Tidy from LLVM package to the MSVC compiler toolchain. The actual warnings in the code will be addressed as a part of the Code Quality Days, task T78535. Differential Revision: https://developer.blender.org/D7937
2020-06-05 11:37:49 +02:00
-readability-misleading-indentation,
Clang-Tidy: ignore some newer checks Those checks have been added to clang tidy within the last year. They fail when I use a clang tidy version I built from source. Reviewers: sergey Differential Revision: https://developer.blender.org/D8302
2020-07-15 14:23:51 +02:00
-readability-use-anyofallof,
Clang-tidy: Ignore variable name length and .c/.cc include warnings After some internal discussion it was decided that we should ignore name variable length tidy warnings. Otherwise we would have warnings for every variable that is under three characters long. Additionally we will also ignore any warnings when including non header files as the Unity library in our build system uses this excessively
2022-05-06 14:47:45 +02:00
-readability-identifier-length,
Initial support of clang-tidy toolchain Clang Tidy is a Clang based "linter" tool which goal is to help fixing typical programming errors. It is run as a separate compile step of every file, which slows compilation down but allows to fully analyze the file the same way as compiler does and catch non-trivial bugprone cases. This change includes: - CMake option called `WITH_CLANG_TIDY` which enables Clang Tidy linter tool on all source in the `source/` directory. This option is only available on Linux, as it is currently the easiest platform to get the Clang Tidy toolchain to work. - CMake module which is aimed to find latest available Clang Tidy. - Set of rules which allows to have Blender fully compiled without extra issues. The goal of this change is to provide a base ground so that solving all the warnings can happen later on, as a team effort. It should be possible to use Clang Tidy side-by-side with both GCC and Clang, but there seems to be some tweaks to be done in CMake to make it really work for Blender. For now use Clang toolchain if there are issues with GCC+Clang Tidy. It will be worked on in the nearest future to bring seamless experience for all configurations. Currently there is no official way of getting Clang Tidy on macOS, and on Windows there are some difficulties of hooking up Clang Tidy from LLVM package to the MSVC compiler toolchain. The actual warnings in the code will be addressed as a part of the Code Quality Days, task T78535. Differential Revision: https://developer.blender.org/D7937
2020-06-05 11:37:49 +02:00
Clang-tidy: disable new warnings. Until it is decided whether to work on, or ignore these warning, disable them. See T78535 Reviewed By: sergey Differential Revision: https://developer.blender.org/D9281
2020-10-21 09:27:08 +02:00
-readability-function-cognitive-complexity,
Initial support of clang-tidy toolchain Clang Tidy is a Clang based "linter" tool which goal is to help fixing typical programming errors. It is run as a separate compile step of every file, which slows compilation down but allows to fully analyze the file the same way as compiler does and catch non-trivial bugprone cases. This change includes: - CMake option called `WITH_CLANG_TIDY` which enables Clang Tidy linter tool on all source in the `source/` directory. This option is only available on Linux, as it is currently the easiest platform to get the Clang Tidy toolchain to work. - CMake module which is aimed to find latest available Clang Tidy. - Set of rules which allows to have Blender fully compiled without extra issues. The goal of this change is to provide a base ground so that solving all the warnings can happen later on, as a team effort. It should be possible to use Clang Tidy side-by-side with both GCC and Clang, but there seems to be some tweaks to be done in CMake to make it really work for Blender. For now use Clang toolchain if there are issues with GCC+Clang Tidy. It will be worked on in the nearest future to bring seamless experience for all configurations. Currently there is no official way of getting Clang Tidy on macOS, and on Windows there are some difficulties of hooking up Clang Tidy from LLVM package to the MSVC compiler toolchain. The actual warnings in the code will be addressed as a part of the Code Quality Days, task T78535. Differential Revision: https://developer.blender.org/D7937
2020-06-05 11:37:49 +02:00
bugprone-*,
-bugprone-narrowing-conversions,
-bugprone-unhandled-self-assignment,
-bugprone-branch-clone,
-bugprone-macro-parentheses,
Clang-Tidy: ignore some newer checks Those checks have been added to clang tidy within the last year. They fail when I use a clang tidy version I built from source. Reviewers: sergey Differential Revision: https://developer.blender.org/D8302
2020-07-15 14:23:51 +02:00
-bugprone-reserved-identifier,
Clang Tidy: ignore some passes that changed or were added in version 13 I get hundreds of clang-tidy errors without ignoring those passes right now. To not forget about the passes, I added them to T78535.
2021-11-23 19:45:05 +01:00
-bugprone-easily-swappable-parameters,
-bugprone-implicit-widening-of-multiplication-result,
Initial support of clang-tidy toolchain Clang Tidy is a Clang based "linter" tool which goal is to help fixing typical programming errors. It is run as a separate compile step of every file, which slows compilation down but allows to fully analyze the file the same way as compiler does and catch non-trivial bugprone cases. This change includes: - CMake option called `WITH_CLANG_TIDY` which enables Clang Tidy linter tool on all source in the `source/` directory. This option is only available on Linux, as it is currently the easiest platform to get the Clang Tidy toolchain to work. - CMake module which is aimed to find latest available Clang Tidy. - Set of rules which allows to have Blender fully compiled without extra issues. The goal of this change is to provide a base ground so that solving all the warnings can happen later on, as a team effort. It should be possible to use Clang Tidy side-by-side with both GCC and Clang, but there seems to be some tweaks to be done in CMake to make it really work for Blender. For now use Clang toolchain if there are issues with GCC+Clang Tidy. It will be worked on in the nearest future to bring seamless experience for all configurations. Currently there is no official way of getting Clang Tidy on macOS, and on Windows there are some difficulties of hooking up Clang Tidy from LLVM package to the MSVC compiler toolchain. The actual warnings in the code will be addressed as a part of the Code Quality Days, task T78535. Differential Revision: https://developer.blender.org/D7937
2020-06-05 11:37:49 +02:00
-bugprone-sizeof-expression,
-bugprone-integer-division,
Clang-tidy: disable new warnings. Until it is decided whether to work on, or ignore these warning, disable them. See T78535 Reviewed By: sergey Differential Revision: https://developer.blender.org/D9281
2020-10-21 09:27:08 +02:00
-bugprone-redundant-branch-condition,
Clang-tidy: Ignore variable name length and .c/.cc include warnings After some internal discussion it was decided that we should ignore name variable length tidy warnings. Otherwise we would have warnings for every variable that is under three characters long. Additionally we will also ignore any warnings when including non header files as the Unity library in our build system uses this excessively
2022-05-06 14:47:45 +02:00
-bugprone-suspicious-include,
Clang Tidy: Expand modernize category Gives an idea of which warnings are affecting Blender code base.
2020-11-06 12:15:35 +01:00
modernize-*,
-modernize-use-auto,
-modernize-use-trailing-return-type,
-modernize-avoid-c-arrays,
-modernize-use-nodiscard,
-modernize-loop-convert,
-modernize-pass-by-value,
Clang Tidy: ignore some passes that changed or were added in version 13 I get hundreds of clang-tidy errors without ignoring those passes right now. To not forget about the passes, I added them to T78535.
2021-11-23 19:45:05 +01:00
-modernize-raw-string-literal,
-modernize-return-braced-init-list
Clang Tidy: Expand modernize category Gives an idea of which warnings are affecting Blender code base.
2020-11-06 12:15:35 +01:00
Cleanup: Clang-tidy modernize-use-default-member-init Using assignment syntax as we don't use `{}` initialization yet. Reviewed By: sergey Differential Revision: https://developer.blender.org/D9501
2021-02-05 14:39:36 +01:00
CheckOptions:
- key: modernize-use-default-member-init.UseAssignment
value: 1