tmaq
/
tornavis
1
0
Fork 0
Code Issues 2 Pull Requests 29 Packages Projects 24 Releases Wiki Activity

Cleanup: return const reference instead of copy 

There isn't really a reason for why this has to return a copy of
the data instead of a reference.
This commit is contained in:
Jacques Lucke 2021-02-18 12:40:27 +01:00
parent e1fe1fcc79
commit 0fe5be3525
2 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/functions/FN_generic_value_map.hh
View File

@ -104,14 +104,12 @@ template<typename Key> class GValueMap {
return return_value;
}
template<typename T, typename ForwardKey> T lookup(const ForwardKey &key) const
template<typename T, typename ForwardKey> const T &lookup(const ForwardKey &key) const
{
GMutablePointer value = values_.lookup_as(key);
const CPPType &type = *value.type();
BLI_assert(type.is<T>());
T return_value;
type.copy_to_initialized(value.get(), &return_value);
return return_value;
BLI_assert(value.is_type<T>());
BLI_assert(value.get() != nullptr);
return *(const T *)value.get();
}
template<typename ForwardKey> bool contains(const ForwardKey &key) const

5
source/blender/nodes/NOD_geometry_exec.hh
View File

@ -133,11 +133,8 @@ class GeoNodeExecParams {
/**
* Get the input value for the input socket with the given identifier.
*
* This makes a copy of the value, which is fine for most types but should be avoided for
* geometry sets.
*/
template<typename T> T get_input(StringRef identifier) const
template<typename T> const T &get_input(StringRef identifier) const
{
#ifdef DEBUG
this->check_extract_input(identifier, &CPPType::get<T>());