From 4a5389816b4240eb9f06bb469bf5b308a4b7f13c Mon Sep 17 00:00:00 2001 From: Jacques Lucke Date: Fri, 3 Jul 2020 17:07:01 +0200 Subject: [PATCH] Clang-Tidy: enable readability-named-parameter --- .clang-tidy | 1 - source/blender/blenlib/intern/task_range.cc | 2 +- .../blender/blenloader/intern/readblenentry.c | 2 +- source/blender/editors/space_file/filelist.c | 24 ++++++++++++++----- .../intern/scene_graph/ScenePrettyPrinter.cpp | 16 ++++++------- .../freestyle/intern/view_map/Interface0D.cpp | 4 +++- .../intern/view_map/ViewMapTesselator.cpp | 2 +- .../intern/winged_edge/Curvature.cpp | 2 +- .../intern/winged_edge/WingedEdgeBuilder.cpp | 2 +- .../io/usd/intern/usd_hierarchy_iterator.cc | 4 +++- .../blender/io/usd/intern/usd_writer_hair.cc | 2 +- 11 files changed, 38 insertions(+), 23 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index b39d77136f2..e68834d7f1a 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -17,7 +17,6 @@ Checks: > -readability-inconsistent-declaration-parameter-name, -readability-non-const-parameter, -readability-redundant-preprocessor, - -readability-named-parameter, -readability-function-size, -readability-function-size, -readability-redundant-string-init, diff --git a/source/blender/blenlib/intern/task_range.cc b/source/blender/blenlib/intern/task_range.cc index 67d8960434e..27e0fb0ed07 100644 --- a/source/blender/blenlib/intern/task_range.cc +++ b/source/blender/blenlib/intern/task_range.cc @@ -62,7 +62,7 @@ struct RangeTask { } /* Splitting constructor for parallel reduce. */ - RangeTask(RangeTask &other, tbb::split) + RangeTask(RangeTask &other, tbb::split /* unused */) : func(other.func), userdata(other.userdata), settings(other.settings) { init_chunk(settings->userdata_chunk); diff --git a/source/blender/blenloader/intern/readblenentry.c b/source/blender/blenloader/intern/readblenentry.c index 914eb6c4690..e4129282a68 100644 --- a/source/blender/blenloader/intern/readblenentry.c +++ b/source/blender/blenloader/intern/readblenentry.c @@ -56,7 +56,7 @@ #endif /* local prototypes --------------------- */ -void BLO_blendhandle_print_sizes(BlendHandle *, void *); +void BLO_blendhandle_print_sizes(BlendHandle *bh, void *fp); /* Access routines used by filesel. */ diff --git a/source/blender/editors/space_file/filelist.c b/source/blender/editors/space_file/filelist.c index f60ef2b6aed..6b39dc4ae15 100644 --- a/source/blender/editors/space_file/filelist.c +++ b/source/blender/editors/space_file/filelist.c @@ -359,12 +359,24 @@ enum { static ImBuf *gSpecialFileImages[SPECIAL_IMG_MAX]; -static void filelist_readjob_main( - struct FileList *, const char *, short *, short *, float *, ThreadMutex *); -static void filelist_readjob_lib( - struct FileList *, const char *, short *, short *, float *, ThreadMutex *); -static void filelist_readjob_dir( - struct FileList *, const char *, short *, short *, float *, ThreadMutex *); +static void filelist_readjob_main(FileList *filelist, + const char *main_name, + short *stop, + short *do_update, + float *progress, + ThreadMutex *lock); +static void filelist_readjob_lib(FileList *filelist, + const char *main_name, + short *stop, + short *do_update, + float *progress, + ThreadMutex *lock); +static void filelist_readjob_dir(FileList *filelist, + const char *main_name, + short *stop, + short *do_update, + float *progress, + ThreadMutex *lock); /* helper, could probably go in BKE actually? */ static int groupname_to_code(const char *group); diff --git a/source/blender/freestyle/intern/scene_graph/ScenePrettyPrinter.cpp b/source/blender/freestyle/intern/scene_graph/ScenePrettyPrinter.cpp index 0c533232179..33aa368d755 100644 --- a/source/blender/freestyle/intern/scene_graph/ScenePrettyPrinter.cpp +++ b/source/blender/freestyle/intern/scene_graph/ScenePrettyPrinter.cpp @@ -39,42 +39,42 @@ VISIT(NodeLight) VISIT(NodeDrawingStyle) VISIT(NodeTransform) -void ScenePrettyPrinter::visitNodeShapeBefore(NodeShape &) +void ScenePrettyPrinter::visitNodeShapeBefore(NodeShape &UNUSED(shape)) { increaseSpace(); } -void ScenePrettyPrinter::visitNodeShapeAfter(NodeShape &) +void ScenePrettyPrinter::visitNodeShapeAfter(NodeShape &UNUSED(shape)) { decreaseSpace(); } -void ScenePrettyPrinter::visitNodeGroupBefore(NodeGroup &) +void ScenePrettyPrinter::visitNodeGroupBefore(NodeGroup &UNUSED(group)) { increaseSpace(); } -void ScenePrettyPrinter::visitNodeGroupAfter(NodeGroup &) +void ScenePrettyPrinter::visitNodeGroupAfter(NodeGroup &UNUSED(group)) { decreaseSpace(); } -void ScenePrettyPrinter::visitNodeDrawingStyleBefore(NodeDrawingStyle &) +void ScenePrettyPrinter::visitNodeDrawingStyleBefore(NodeDrawingStyle &UNUSED(style)) { increaseSpace(); } -void ScenePrettyPrinter::visitNodeDrawingStyleAfter(NodeDrawingStyle &) +void ScenePrettyPrinter::visitNodeDrawingStyleAfter(NodeDrawingStyle &UNUSED(style)) { decreaseSpace(); } -void ScenePrettyPrinter::visitNodeTransformBefore(NodeTransform &) +void ScenePrettyPrinter::visitNodeTransformBefore(NodeTransform &UNUSED(transform)) { increaseSpace(); } -void ScenePrettyPrinter::visitNodeTransformAfter(NodeTransform &) +void ScenePrettyPrinter::visitNodeTransformAfter(NodeTransform &UNUSED(transform)) { decreaseSpace(); } diff --git a/source/blender/freestyle/intern/view_map/Interface0D.cpp b/source/blender/freestyle/intern/view_map/Interface0D.cpp index fc5a797cc87..2961b0f58e5 100644 --- a/source/blender/freestyle/intern/view_map/Interface0D.cpp +++ b/source/blender/freestyle/intern/view_map/Interface0D.cpp @@ -24,6 +24,8 @@ extern "C" { #include "Interface0D.h" +#include "BLI_utildefines.h" + namespace Freestyle { real Interface0D::getX() const @@ -74,7 +76,7 @@ Geometry::Vec2r Interface0D::getPoint2D() const return 0; } -FEdge *Interface0D::getFEdge(Interface0D &) +FEdge *Interface0D::getFEdge(Interface0D &UNUSED(element)) { PyErr_SetString(PyExc_TypeError, "method getFEdge() not properly overridden"); return 0; diff --git a/source/blender/freestyle/intern/view_map/ViewMapTesselator.cpp b/source/blender/freestyle/intern/view_map/ViewMapTesselator.cpp index ef79384e2af..54de3321b80 100644 --- a/source/blender/freestyle/intern/view_map/ViewMapTesselator.cpp +++ b/source/blender/freestyle/intern/view_map/ViewMapTesselator.cpp @@ -33,7 +33,7 @@ NodeGroup *ViewMapTesselator::Tesselate(ViewMap *iViewMap) return Tesselate(viewedges.begin(), viewedges.end()); } -NodeGroup *ViewMapTesselator::Tesselate(WShape *) +NodeGroup *ViewMapTesselator::Tesselate(WShape *UNUSED(shape)) { return NULL; } diff --git a/source/blender/freestyle/intern/winged_edge/Curvature.cpp b/source/blender/freestyle/intern/winged_edge/Curvature.cpp index 96b313d4e01..1702a22c678 100644 --- a/source/blender/freestyle/intern/winged_edge/Curvature.cpp +++ b/source/blender/freestyle/intern/winged_edge/Curvature.cpp @@ -59,7 +59,7 @@ static bool angle_obtuse(WVertex *v, WFace *f) // FIXME // WVvertex is useless but kept for history reasons -static bool triangle_obtuse(WVertex *, WFace *f) +static bool triangle_obtuse(WVertex *UNUSED(v), WFace *f) { bool b = false; for (int i = 0; i < 3; i++) { diff --git a/source/blender/freestyle/intern/winged_edge/WingedEdgeBuilder.cpp b/source/blender/freestyle/intern/winged_edge/WingedEdgeBuilder.cpp index e7224336353..c989d77a730 100644 --- a/source/blender/freestyle/intern/winged_edge/WingedEdgeBuilder.cpp +++ b/source/blender/freestyle/intern/winged_edge/WingedEdgeBuilder.cpp @@ -64,7 +64,7 @@ void WingedEdgeBuilder::visitNodeTransform(NodeTransform &tn) _current_matrix = new_matrix; } -void WingedEdgeBuilder::visitNodeTransformAfter(NodeTransform &) +void WingedEdgeBuilder::visitNodeTransformAfter(NodeTransform &UNUSED(transform)) { delete _current_matrix; diff --git a/source/blender/io/usd/intern/usd_hierarchy_iterator.cc b/source/blender/io/usd/intern/usd_hierarchy_iterator.cc index 388b588b331..f42349d99e8 100644 --- a/source/blender/io/usd/intern/usd_hierarchy_iterator.cc +++ b/source/blender/io/usd/intern/usd_hierarchy_iterator.cc @@ -34,6 +34,7 @@ #include "BKE_duplilist.h" #include "BLI_assert.h" +#include "BLI_utildefines.h" #include "DEG_depsgraph_query.h" @@ -142,7 +143,8 @@ AbstractHierarchyWriter *USDHierarchyIterator::create_hair_writer(const Hierarch return new USDHairWriter(create_usd_export_context(context)); } -AbstractHierarchyWriter *USDHierarchyIterator::create_particle_writer(const HierarchyContext *) +AbstractHierarchyWriter *USDHierarchyIterator::create_particle_writer( + const HierarchyContext *UNUSED(context)) { return nullptr; } diff --git a/source/blender/io/usd/intern/usd_writer_hair.cc b/source/blender/io/usd/intern/usd_writer_hair.cc index 0e0256bdb69..0fd5c4ce727 100644 --- a/source/blender/io/usd/intern/usd_writer_hair.cc +++ b/source/blender/io/usd/intern/usd_writer_hair.cc @@ -82,7 +82,7 @@ void USDHairWriter::do_write(HierarchyContext &context) } } -bool USDHairWriter::check_is_animated(const HierarchyContext &) const +bool USDHairWriter::check_is_animated(const HierarchyContext &UNUSED(context)) const { return true; }