From 3740f7593d7146135c2d2fac363f8aed4ba41cf0 Mon Sep 17 00:00:00 2001 From: Bastien Montagne Date: Tue, 8 May 2018 15:04:10 +0200 Subject: [PATCH] Cleanup: Nuke empty dummy wrappers around modifier_copyData_generic(). This also changes signature of modifier copy callback, first (source) parameter is now a const, which is saner anyway! --- source/blender/blenkernel/BKE_dynamicpaint.h | 2 +- source/blender/blenkernel/BKE_modifier.h | 2 +- source/blender/blenkernel/BKE_smoke.h | 2 +- source/blender/blenkernel/intern/dynamicpaint.c | 2 +- source/blender/blenkernel/intern/smoke.c | 2 +- source/blender/modifiers/intern/MOD_armature.c | 4 ++-- source/blender/modifiers/intern/MOD_array.c | 11 +---------- source/blender/modifiers/intern/MOD_bevel.c | 11 +---------- source/blender/modifiers/intern/MOD_boolean.c | 11 +---------- source/blender/modifiers/intern/MOD_build.c | 11 +---------- source/blender/modifiers/intern/MOD_cast.c | 12 +----------- source/blender/modifiers/intern/MOD_cloth.c | 4 ++-- source/blender/modifiers/intern/MOD_collision.c | 5 +---- .../blender/modifiers/intern/MOD_correctivesmooth.c | 4 ++-- source/blender/modifiers/intern/MOD_curve.c | 11 +---------- source/blender/modifiers/intern/MOD_datatransfer.c | 11 +---------- source/blender/modifiers/intern/MOD_decimate.c | 11 +---------- source/blender/modifiers/intern/MOD_displace.c | 12 +----------- source/blender/modifiers/intern/MOD_dynamicpaint.c | 4 ++-- source/blender/modifiers/intern/MOD_edgesplit.c | 11 +---------- source/blender/modifiers/intern/MOD_explode.c | 4 ++-- source/blender/modifiers/intern/MOD_fluidsim.c | 4 ++-- source/blender/modifiers/intern/MOD_hook.c | 4 ++-- .../blender/modifiers/intern/MOD_laplaciandeform.c | 4 ++-- .../blender/modifiers/intern/MOD_laplaciansmooth.c | 13 +------------ source/blender/modifiers/intern/MOD_lattice.c | 12 +----------- source/blender/modifiers/intern/MOD_mask.c | 11 +---------- source/blender/modifiers/intern/MOD_meshcache.c | 11 +---------- source/blender/modifiers/intern/MOD_meshdeform.c | 4 ++-- .../modifiers/intern/MOD_meshsequencecache.c | 6 +++--- source/blender/modifiers/intern/MOD_mirror.c | 11 +---------- source/blender/modifiers/intern/MOD_multires.c | 11 +---------- source/blender/modifiers/intern/MOD_normal_edit.c | 7 +------ source/blender/modifiers/intern/MOD_ocean.c | 4 ++-- .../blender/modifiers/intern/MOD_particleinstance.c | 10 +--------- .../blender/modifiers/intern/MOD_particlesystem.c | 6 ++++-- source/blender/modifiers/intern/MOD_remesh.c | 11 +---------- source/blender/modifiers/intern/MOD_screw.c | 11 +---------- source/blender/modifiers/intern/MOD_shrinkwrap.c | 11 +---------- source/blender/modifiers/intern/MOD_simpledeform.c | 11 +---------- source/blender/modifiers/intern/MOD_skin.c | 11 +---------- source/blender/modifiers/intern/MOD_smoke.c | 4 ++-- source/blender/modifiers/intern/MOD_smooth.c | 11 +---------- source/blender/modifiers/intern/MOD_solidify.c | 11 +---------- source/blender/modifiers/intern/MOD_subsurf.c | 5 ++--- source/blender/modifiers/intern/MOD_surfacedeform.c | 4 ++-- source/blender/modifiers/intern/MOD_triangulate.c | 12 +----------- source/blender/modifiers/intern/MOD_uvproject.c | 4 ++-- source/blender/modifiers/intern/MOD_uvwarp.c | 11 +---------- source/blender/modifiers/intern/MOD_warp.c | 4 ++-- source/blender/modifiers/intern/MOD_wave.c | 12 +----------- source/blender/modifiers/intern/MOD_weightvgedit.c | 4 ++-- source/blender/modifiers/intern/MOD_weightvgmix.c | 12 +----------- .../modifiers/intern/MOD_weightvgproximity.c | 12 +----------- source/blender/modifiers/intern/MOD_wireframe.c | 11 +---------- 55 files changed, 76 insertions(+), 361 deletions(-) diff --git a/source/blender/blenkernel/BKE_dynamicpaint.h b/source/blender/blenkernel/BKE_dynamicpaint.h index 5abb53d4c52..5bf9dd84702 100644 --- a/source/blender/blenkernel/BKE_dynamicpaint.h +++ b/source/blender/blenkernel/BKE_dynamicpaint.h @@ -62,7 +62,7 @@ typedef struct PaintWavePoint { struct DerivedMesh *dynamicPaint_Modifier_do(struct DynamicPaintModifierData *pmd, struct Scene *scene, struct Object *ob, struct DerivedMesh *dm); void dynamicPaint_Modifier_free(struct DynamicPaintModifierData *pmd); -void dynamicPaint_Modifier_copy(struct DynamicPaintModifierData *pmd, struct DynamicPaintModifierData *tsmd); +void dynamicPaint_Modifier_copy(const struct DynamicPaintModifierData *pmd, struct DynamicPaintModifierData *tsmd); bool dynamicPaint_createType(struct DynamicPaintModifierData *pmd, int type, struct Scene *scene); struct DynamicPaintSurface *dynamicPaint_createNewSurface(struct DynamicPaintCanvasSettings *canvas, struct Scene *scene); diff --git a/source/blender/blenkernel/BKE_modifier.h b/source/blender/blenkernel/BKE_modifier.h index 18cde156f5e..f5c5b74a2ae 100644 --- a/source/blender/blenkernel/BKE_modifier.h +++ b/source/blender/blenkernel/BKE_modifier.h @@ -160,7 +160,7 @@ typedef struct ModifierTypeInfo { /* Copy instance data for this modifier type. Should copy all user * level settings to the target modifier. */ - void (*copyData)(struct ModifierData *md, struct ModifierData *target); + void (*copyData)(const struct ModifierData *md, struct ModifierData *target); /********************* Deform modifier functions *********************/ diff --git a/source/blender/blenkernel/BKE_smoke.h b/source/blender/blenkernel/BKE_smoke.h index 20366f00df6..a54d50cb154 100644 --- a/source/blender/blenkernel/BKE_smoke.h +++ b/source/blender/blenkernel/BKE_smoke.h @@ -43,7 +43,7 @@ void smokeModifier_free(struct SmokeModifierData *smd); void smokeModifier_reset(struct SmokeModifierData *smd); void smokeModifier_reset_turbulence(struct SmokeModifierData *smd); void smokeModifier_createType(struct SmokeModifierData *smd); -void smokeModifier_copy(struct SmokeModifierData *smd, struct SmokeModifierData *tsmd); +void smokeModifier_copy(const SmokeModifierData *smd, struct SmokeModifierData *tsmd); float smoke_get_velocity_at(struct Object *ob, float position[3], float velocity[3]); int smoke_get_data_flags(struct SmokeDomainSettings *sds); diff --git a/source/blender/blenkernel/intern/dynamicpaint.c b/source/blender/blenkernel/intern/dynamicpaint.c index c34bd2493eb..a1f55704256 100644 --- a/source/blender/blenkernel/intern/dynamicpaint.c +++ b/source/blender/blenkernel/intern/dynamicpaint.c @@ -1160,7 +1160,7 @@ bool dynamicPaint_createType(struct DynamicPaintModifierData *pmd, int type, str return true; } -void dynamicPaint_Modifier_copy(struct DynamicPaintModifierData *pmd, struct DynamicPaintModifierData *tpmd) +void dynamicPaint_Modifier_copy(const struct DynamicPaintModifierData *pmd, struct DynamicPaintModifierData *tpmd) { /* Init modifier */ tpmd->type = pmd->type; diff --git a/source/blender/blenkernel/intern/smoke.c b/source/blender/blenkernel/intern/smoke.c index 699f546bbef..a8db1ac16d2 100644 --- a/source/blender/blenkernel/intern/smoke.c +++ b/source/blender/blenkernel/intern/smoke.c @@ -603,7 +603,7 @@ void smokeModifier_createType(struct SmokeModifierData *smd) } } -void smokeModifier_copy(struct SmokeModifierData *smd, struct SmokeModifierData *tsmd) +void smokeModifier_copy(const struct SmokeModifierData *smd, struct SmokeModifierData *tsmd) { tsmd->type = smd->type; tsmd->time = smd->time; diff --git a/source/blender/modifiers/intern/MOD_armature.c b/source/blender/modifiers/intern/MOD_armature.c index 579854be725..15f0dc698e8 100644 --- a/source/blender/modifiers/intern/MOD_armature.c +++ b/source/blender/modifiers/intern/MOD_armature.c @@ -62,10 +62,10 @@ static void initData(ModifierData *md) amd->deformflag = ARM_DEF_VGROUP; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { #if 0 - ArmatureModifierData *amd = (ArmatureModifierData *) md; + const ArmatureModifierData *amd = (const ArmatureModifierData *) md; #endif ArmatureModifierData *tamd = (ArmatureModifierData *) target; diff --git a/source/blender/modifiers/intern/MOD_array.c b/source/blender/modifiers/intern/MOD_array.c index 5119f9e9d8e..0be5049012d 100644 --- a/source/blender/modifiers/intern/MOD_array.c +++ b/source/blender/modifiers/intern/MOD_array.c @@ -82,15 +82,6 @@ static void initData(ModifierData *md) amd->flags = 0; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - ArrayModifierData *amd = (ArrayModifierData *) md; - ArrayModifierData *tamd = (ArrayModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static void foreachObjectLink( ModifierData *md, Object *ob, ObjectWalkFunc walk, void *userData) @@ -820,7 +811,7 @@ ModifierTypeInfo modifierType_Array = { eModifierTypeFlag_EnableInEditmode | eModifierTypeFlag_AcceptsCVs, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_bevel.c b/source/blender/modifiers/intern/MOD_bevel.c index 93dc0203f83..bd37358011b 100644 --- a/source/blender/modifiers/intern/MOD_bevel.c +++ b/source/blender/modifiers/intern/MOD_bevel.c @@ -63,15 +63,6 @@ static void initData(ModifierData *md) bmd->defgrp_name[0] = '\0'; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - BevelModifierData *bmd = (BevelModifierData *) md; - BevelModifierData *tbmd = (BevelModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { BevelModifierData *bmd = (BevelModifierData *)md; @@ -194,7 +185,7 @@ ModifierTypeInfo modifierType_Bevel = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_boolean.c b/source/blender/modifiers/intern/MOD_boolean.c index 93c4d83870a..1f683f52122 100644 --- a/source/blender/modifiers/intern/MOD_boolean.c +++ b/source/blender/modifiers/intern/MOD_boolean.c @@ -72,15 +72,6 @@ static void initData(ModifierData *md) bmd->double_threshold = 1e-6f; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - BooleanModifierData *bmd = (BooleanModifierData *) md; - BooleanModifierData *tbmd = (BooleanModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static bool isDisabled(ModifierData *md, int UNUSED(useRenderParams)) { BooleanModifierData *bmd = (BooleanModifierData *) md; @@ -366,7 +357,7 @@ ModifierTypeInfo modifierType_Boolean = { /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_UsesPointCache, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_build.c b/source/blender/modifiers/intern/MOD_build.c index f71d14efb2b..75afd7496a1 100644 --- a/source/blender/modifiers/intern/MOD_build.c +++ b/source/blender/modifiers/intern/MOD_build.c @@ -61,15 +61,6 @@ static void initData(ModifierData *md) bmd->length = 100.0; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - BuildModifierData *bmd = (BuildModifierData *) md; - BuildModifierData *tbmd = (BuildModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static bool dependsOnTime(ModifierData *UNUSED(md)) { return true; @@ -313,7 +304,7 @@ ModifierTypeInfo modifierType_Build = { /* type */ eModifierTypeType_Nonconstructive, /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_AcceptsCVs, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_cast.c b/source/blender/modifiers/intern/MOD_cast.c index 60465df0492..bac95e4c1c1 100644 --- a/source/blender/modifiers/intern/MOD_cast.c +++ b/source/blender/modifiers/intern/MOD_cast.c @@ -63,16 +63,6 @@ static void initData(ModifierData *md) cmd->object = NULL; } - -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - CastModifierData *cmd = (CastModifierData *) md; - CastModifierData *tcmd = (CastModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static bool isDisabled(ModifierData *md, int UNUSED(useRenderParams)) { CastModifierData *cmd = (CastModifierData *) md; @@ -494,7 +484,7 @@ ModifierTypeInfo modifierType_Cast = { eModifierTypeFlag_AcceptsLattice | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_cloth.c b/source/blender/modifiers/intern/MOD_cloth.c index 2b181c0fb18..3f9ab9c7c1c 100644 --- a/source/blender/modifiers/intern/MOD_cloth.c +++ b/source/blender/modifiers/intern/MOD_cloth.c @@ -157,9 +157,9 @@ static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) return dataMask; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - ClothModifierData *clmd = (ClothModifierData *) md; + const ClothModifierData *clmd = (const ClothModifierData *) md; ClothModifierData *tclmd = (ClothModifierData *) target; if (tclmd->sim_parms) { diff --git a/source/blender/modifiers/intern/MOD_collision.c b/source/blender/modifiers/intern/MOD_collision.c index f2698b43652..6cf6bd36fff 100644 --- a/source/blender/modifiers/intern/MOD_collision.c +++ b/source/blender/modifiers/intern/MOD_collision.c @@ -81,10 +81,7 @@ static void freeData(ModifierData *md) MEM_SAFE_FREE(collmd->current_xnew); MEM_SAFE_FREE(collmd->current_v); - if (collmd->tri) { - MEM_freeN((void *)collmd->tri); - collmd->tri = NULL; - } + MEM_SAFE_FREE(collmd->tri); collmd->time_x = collmd->time_xnew = -1000; collmd->mvert_num = 0; diff --git a/source/blender/modifiers/intern/MOD_correctivesmooth.c b/source/blender/modifiers/intern/MOD_correctivesmooth.c index 08f4588df87..f0590264114 100644 --- a/source/blender/modifiers/intern/MOD_correctivesmooth.c +++ b/source/blender/modifiers/intern/MOD_correctivesmooth.c @@ -80,9 +80,9 @@ static void initData(ModifierData *md) } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - CorrectiveSmoothModifierData *csmd = (CorrectiveSmoothModifierData *)md; + const CorrectiveSmoothModifierData *csmd = (const CorrectiveSmoothModifierData *)md; CorrectiveSmoothModifierData *tcsmd = (CorrectiveSmoothModifierData *)target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_curve.c b/source/blender/modifiers/intern/MOD_curve.c index 7e16bf450fc..91772faa08b 100644 --- a/source/blender/modifiers/intern/MOD_curve.c +++ b/source/blender/modifiers/intern/MOD_curve.c @@ -56,15 +56,6 @@ static void initData(ModifierData *md) cmd->defaxis = MOD_CURVE_POSX; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - CurveModifierData *cmd = (CurveModifierData *) md; - CurveModifierData *tcmd = (CurveModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { CurveModifierData *cmd = (CurveModifierData *)md; @@ -160,7 +151,7 @@ ModifierTypeInfo modifierType_Curve = { eModifierTypeFlag_AcceptsLattice | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_datatransfer.c b/source/blender/modifiers/intern/MOD_datatransfer.c index d810978fb0b..3a8887296f2 100644 --- a/source/blender/modifiers/intern/MOD_datatransfer.c +++ b/source/blender/modifiers/intern/MOD_datatransfer.c @@ -217,15 +217,6 @@ static DerivedMesh *applyModifier(ModifierData *md, Object *ob, DerivedMesh *der #undef HIGH_POLY_WARNING #undef DT_TYPES_AFFECT_MESH -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - DataTransferModifierData *dtmd = (DecimateModifierData *) md; - DataTransferModifierData *tdtmd = (DecimateModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - ModifierTypeInfo modifierType_DataTransfer = { /* name */ "DataTransfer", /* structName */ "DataTransferModifierData", @@ -236,7 +227,7 @@ ModifierTypeInfo modifierType_DataTransfer = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_UsesPreview, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_decimate.c b/source/blender/modifiers/intern/MOD_decimate.c index 8b5b0542442..56aab400993 100644 --- a/source/blender/modifiers/intern/MOD_decimate.c +++ b/source/blender/modifiers/intern/MOD_decimate.c @@ -64,15 +64,6 @@ static void initData(ModifierData *md) dmd->defgrp_factor = 1.0; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - DecimateModifierData *dmd = (DecimateModifierData *) md; - DecimateModifierData *tdmd = (DecimateModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { DecimateModifierData *dmd = (DecimateModifierData *) md; @@ -216,7 +207,7 @@ ModifierTypeInfo modifierType_Decimate = { /* type */ eModifierTypeType_Nonconstructive, /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_AcceptsCVs, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_displace.c b/source/blender/modifiers/intern/MOD_displace.c index 72122fae6b4..e63d015ac9a 100644 --- a/source/blender/modifiers/intern/MOD_displace.c +++ b/source/blender/modifiers/intern/MOD_displace.c @@ -71,16 +71,6 @@ static void initData(ModifierData *md) dmd->space = MOD_DISP_SPACE_LOCAL; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - DisplaceModifierData *dmd = (DisplaceModifierData *) md; - DisplaceModifierData *tdmd = (DisplaceModifierData *) target; -#endif - - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { DisplaceModifierData *dmd = (DisplaceModifierData *)md; @@ -427,7 +417,7 @@ ModifierTypeInfo modifierType_Displace = { /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_dynamicpaint.c b/source/blender/modifiers/intern/MOD_dynamicpaint.c index faf06f2d128..9a497acbde1 100644 --- a/source/blender/modifiers/intern/MOD_dynamicpaint.c +++ b/source/blender/modifiers/intern/MOD_dynamicpaint.c @@ -54,9 +54,9 @@ static void initData(ModifierData *md) pmd->type = MOD_DYNAMICPAINT_TYPE_CANVAS; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - DynamicPaintModifierData *pmd = (DynamicPaintModifierData *)md; + const DynamicPaintModifierData *pmd = (const DynamicPaintModifierData *)md; DynamicPaintModifierData *tpmd = (DynamicPaintModifierData *)target; dynamicPaint_Modifier_copy(pmd, tpmd); diff --git a/source/blender/modifiers/intern/MOD_edgesplit.c b/source/blender/modifiers/intern/MOD_edgesplit.c index a17870f2bf4..849cca53005 100644 --- a/source/blender/modifiers/intern/MOD_edgesplit.c +++ b/source/blender/modifiers/intern/MOD_edgesplit.c @@ -112,15 +112,6 @@ static void initData(ModifierData *md) emd->flags = MOD_EDGESPLIT_FROMANGLE | MOD_EDGESPLIT_FROMFLAG; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - EdgeSplitModifierData *emd = (EdgeSplitModifierData *) md; - EdgeSplitModifierData *temd = (EdgeSplitModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static DerivedMesh *applyModifier(ModifierData *md, Object *UNUSED(ob), DerivedMesh *dm, ModifierApplyFlag UNUSED(flag)) { @@ -147,7 +138,7 @@ ModifierTypeInfo modifierType_EdgeSplit = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_explode.c b/source/blender/modifiers/intern/MOD_explode.c index 600dc3e28d1..2d4a4a89f71 100644 --- a/source/blender/modifiers/intern/MOD_explode.c +++ b/source/blender/modifiers/intern/MOD_explode.c @@ -68,10 +68,10 @@ static void freeData(ModifierData *md) MEM_SAFE_FREE(emd->facepa); } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { #if 0 - ExplodeModifierData *emd = (ExplodeModifierData *) md; + const ExplodeModifierData *emd = (const ExplodeModifierData *) md; #endif ExplodeModifierData *temd = (ExplodeModifierData *) target; diff --git a/source/blender/modifiers/intern/MOD_fluidsim.c b/source/blender/modifiers/intern/MOD_fluidsim.c index 823e67a7bc9..78dd130509e 100644 --- a/source/blender/modifiers/intern/MOD_fluidsim.c +++ b/source/blender/modifiers/intern/MOD_fluidsim.c @@ -65,9 +65,9 @@ static void freeData(ModifierData *md) fluidsim_free(fluidmd); } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - FluidsimModifierData *fluidmd = (FluidsimModifierData *) md; + const FluidsimModifierData *fluidmd = (const FluidsimModifierData *) md; FluidsimModifierData *tfluidmd = (FluidsimModifierData *) target; if (fluidmd->fss) { diff --git a/source/blender/modifiers/intern/MOD_hook.c b/source/blender/modifiers/intern/MOD_hook.c index 80f07f579cd..1763e9ab863 100644 --- a/source/blender/modifiers/intern/MOD_hook.c +++ b/source/blender/modifiers/intern/MOD_hook.c @@ -62,9 +62,9 @@ static void initData(ModifierData *md) hmd->flag = 0; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - HookModifierData *hmd = (HookModifierData *) md; + const HookModifierData *hmd = (const HookModifierData *) md; HookModifierData *thmd = (HookModifierData *) target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_laplaciandeform.c b/source/blender/modifiers/intern/MOD_laplaciandeform.c index 91d41a6badd..fda68e071f0 100644 --- a/source/blender/modifiers/intern/MOD_laplaciandeform.c +++ b/source/blender/modifiers/intern/MOD_laplaciandeform.c @@ -698,9 +698,9 @@ static void initData(ModifierData *md) lmd->flag = 0; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - LaplacianDeformModifierData *lmd = (LaplacianDeformModifierData *)md; + const LaplacianDeformModifierData *lmd = (const LaplacianDeformModifierData *)md; LaplacianDeformModifierData *tlmd = (LaplacianDeformModifierData *)target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_laplaciansmooth.c b/source/blender/modifiers/intern/MOD_laplaciansmooth.c index b3a542f68b7..e9f62713cd1 100644 --- a/source/blender/modifiers/intern/MOD_laplaciansmooth.c +++ b/source/blender/modifiers/intern/MOD_laplaciansmooth.c @@ -81,7 +81,6 @@ static CustomDataMask required_data_mask(Object *ob, ModifierData *md); static bool is_disabled(ModifierData *md, int useRenderParams); static float compute_volume(const float center[3], float (*vertexCos)[3], const MPoly *mpoly, int numPolys, const MLoop *mloop); static LaplacianSystem *init_laplacian_system(int a_numEdges, int a_numPolys, int a_numLoops, int a_numVerts); -static void copy_data(ModifierData *md, ModifierData *target); static void delete_laplacian_system(LaplacianSystem *sys); static void fill_laplacian_matrix(LaplacianSystem *sys); static void init_data(ModifierData *md); @@ -472,16 +471,6 @@ static void init_data(ModifierData *md) smd->defgrp_name[0] = '\0'; } -static void copy_data(ModifierData *md, ModifierData *target) -{ -#if 0 - LaplacianSmoothModifierData *smd = (LaplacianSmoothModifierData *) md; - LaplacianSmoothModifierData *tsmd = (LaplacianSmoothModifierData *) target; -#endif - - modifier_copyData_generic(md, target); -} - static bool is_disabled(ModifierData *md, int UNUSED(useRenderParams)) { LaplacianSmoothModifierData *smd = (LaplacianSmoothModifierData *) md; @@ -550,7 +539,7 @@ ModifierTypeInfo modifierType_LaplacianSmooth = { /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsEditmode, - /* copy_data */ copy_data, + /* copy_data */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_lattice.c b/source/blender/modifiers/intern/MOD_lattice.c index 0df6329cf04..05abd6ebc92 100644 --- a/source/blender/modifiers/intern/MOD_lattice.c +++ b/source/blender/modifiers/intern/MOD_lattice.c @@ -54,16 +54,6 @@ static void initData(ModifierData *md) lmd->strength = 1.0f; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - LatticeModifierData *lmd = (LatticeModifierData *) md; - LatticeModifierData *tlmd = (LatticeModifierData *) target; -#endif - - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { LatticeModifierData *lmd = (LatticeModifierData *)md; @@ -150,7 +140,7 @@ ModifierTypeInfo modifierType_Lattice = { /* flags */ eModifierTypeFlag_AcceptsCVs | eModifierTypeFlag_AcceptsLattice | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_mask.c b/source/blender/modifiers/intern/MOD_mask.c index 351e7116d49..9b5fceac037 100644 --- a/source/blender/modifiers/intern/MOD_mask.c +++ b/source/blender/modifiers/intern/MOD_mask.c @@ -57,15 +57,6 @@ #include "BLI_strict_flags.h" -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - MaskModifierData *mmd = (MaskModifierData *) md; - MaskModifierData *tmmd = (MaskModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *UNUSED(md)) { return CD_MASK_MDEFORMVERT; @@ -384,7 +375,7 @@ ModifierTypeInfo modifierType_Mask = { eModifierTypeFlag_SupportsMapping | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_meshcache.c b/source/blender/modifiers/intern/MOD_meshcache.c index e026d4da29a..b04929049e9 100644 --- a/source/blender/modifiers/intern/MOD_meshcache.c +++ b/source/blender/modifiers/intern/MOD_meshcache.c @@ -64,15 +64,6 @@ static void initData(ModifierData *md) mcmd->up_axis = 2; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - MeshCacheModifierData *mcmd = (MeshCacheModifierData *)md; - MeshCacheModifierData *tmcmd = (MeshCacheModifierData *)target; -#endif - modifier_copyData_generic(md, target); -} - static bool dependsOnTime(ModifierData *md) { MeshCacheModifierData *mcmd = (MeshCacheModifierData *)md; @@ -302,7 +293,7 @@ ModifierTypeInfo modifierType_MeshCache = { eModifierTypeFlag_AcceptsLattice | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_meshdeform.c b/source/blender/modifiers/intern/MOD_meshdeform.c index c125495a234..f606bec8676 100644 --- a/source/blender/modifiers/intern/MOD_meshdeform.c +++ b/source/blender/modifiers/intern/MOD_meshdeform.c @@ -78,9 +78,9 @@ static void freeData(ModifierData *md) if (mmd->bindcos) MEM_freeN(mmd->bindcos); /* deprecated */ } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - MeshDeformModifierData *mmd = (MeshDeformModifierData *) md; + const MeshDeformModifierData *mmd = (const MeshDeformModifierData *) md; MeshDeformModifierData *tmmd = (MeshDeformModifierData *) target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_meshsequencecache.c b/source/blender/modifiers/intern/MOD_meshsequencecache.c index 04de6fae336..e0da66a1734 100644 --- a/source/blender/modifiers/intern/MOD_meshsequencecache.c +++ b/source/blender/modifiers/intern/MOD_meshsequencecache.c @@ -56,10 +56,10 @@ static void initData(ModifierData *md) mcmd->read_flag = MOD_MESHSEQ_READ_ALL; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { #if 0 - MeshSeqCacheModifierData *mcmd = (MeshSeqCacheModifierData *)md; + const MeshSeqCacheModifierData *mcmd = (const MeshSeqCacheModifierData *)md; #endif MeshSeqCacheModifierData *tmcmd = (MeshSeqCacheModifierData *)target; @@ -67,8 +67,8 @@ static void copyData(ModifierData *md, ModifierData *target) if (tmcmd->cache_file) { id_us_plus(&tmcmd->cache_file->id); - tmcmd->reader = NULL; } + tmcmd->reader = NULL; } static void freeData(ModifierData *md) diff --git a/source/blender/modifiers/intern/MOD_mirror.c b/source/blender/modifiers/intern/MOD_mirror.c index 875a1e8d468..72846a7f0e9 100644 --- a/source/blender/modifiers/intern/MOD_mirror.c +++ b/source/blender/modifiers/intern/MOD_mirror.c @@ -59,15 +59,6 @@ static void initData(ModifierData *md) mmd->mirror_ob = NULL; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - MirrorModifierData *mmd = (MirrorModifierData *) md; - MirrorModifierData *tmmd = (MirrorModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static void foreachObjectLink( ModifierData *md, Object *ob, ObjectWalkFunc walk, void *userData) @@ -360,7 +351,7 @@ ModifierTypeInfo modifierType_Mirror = { /* this is only the case when 'MOD_MIR_VGROUP' is used */ eModifierTypeFlag_UsesPreview, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_multires.c b/source/blender/modifiers/intern/MOD_multires.c index f9f17b88fa4..903ef0f3f04 100644 --- a/source/blender/modifiers/intern/MOD_multires.c +++ b/source/blender/modifiers/intern/MOD_multires.c @@ -58,15 +58,6 @@ static void initData(ModifierData *md) mmd->totlvl = 0; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - MultiresModifierData *mmd = (MultiresModifierData *) md; - MultiresModifierData *tmmd = (MultiresModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static DerivedMesh *applyModifier(ModifierData *md, Object *ob, DerivedMesh *dm, ModifierApplyFlag flag) { @@ -152,7 +143,7 @@ ModifierTypeInfo modifierType_Multires = { eModifierTypeFlag_SupportsMapping | eModifierTypeFlag_RequiresOriginalData, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_normal_edit.c b/source/blender/modifiers/intern/MOD_normal_edit.c index 0b703fffda3..894f60e869d 100644 --- a/source/blender/modifiers/intern/MOD_normal_edit.c +++ b/source/blender/modifiers/intern/MOD_normal_edit.c @@ -474,11 +474,6 @@ static void initData(ModifierData *md) enmd->mix_limit = M_PI; } -static void copyData(ModifierData *md, ModifierData *target) -{ - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { NormalEditModifierData *enmd = (NormalEditModifierData *)md; @@ -544,7 +539,7 @@ ModifierTypeInfo modifierType_NormalEdit = { eModifierTypeFlag_SupportsMapping | eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_ocean.c b/source/blender/modifiers/intern/MOD_ocean.c index 240b6247cf5..db31ee05201 100644 --- a/source/blender/modifiers/intern/MOD_ocean.c +++ b/source/blender/modifiers/intern/MOD_ocean.c @@ -159,11 +159,11 @@ static void freeData(ModifierData *md) #endif /* WITH_OCEANSIM */ } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { #ifdef WITH_OCEANSIM #if 0 - OceanModifierData *omd = (OceanModifierData *) md; + const OceanModifierData *omd = (const OceanModifierData *) md; #endif OceanModifierData *tomd = (OceanModifierData *) target; diff --git a/source/blender/modifiers/intern/MOD_particleinstance.c b/source/blender/modifiers/intern/MOD_particleinstance.c index f87eb60e336..47236c0fc32 100644 --- a/source/blender/modifiers/intern/MOD_particleinstance.c +++ b/source/blender/modifiers/intern/MOD_particleinstance.c @@ -71,14 +71,6 @@ static void initData(ModifierData *md) STRNCPY(pimd->index_layer_name, ""); STRNCPY(pimd->value_layer_name, ""); } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - ParticleInstanceModifierData *pimd = (ParticleInstanceModifierData *) md; - ParticleInstanceModifierData *tpimd = (ParticleInstanceModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { @@ -554,7 +546,7 @@ ModifierTypeInfo modifierType_ParticleInstance = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_particlesystem.c b/source/blender/modifiers/intern/MOD_particlesystem.c index d8cccca415c..988a6bc8578 100644 --- a/source/blender/modifiers/intern/MOD_particlesystem.c +++ b/source/blender/modifiers/intern/MOD_particlesystem.c @@ -70,16 +70,18 @@ static void freeData(ModifierData *md) psmd->dm_deformed = NULL; } } + psmd->totdmvert = psmd->totdmedge = psmd->totdmface = 0; /* ED_object_modifier_remove may have freed this first before calling * modifier_free (which calls this function) */ if (psmd->psys) psmd->psys->flag |= PSYS_DELETE; } -static void copyData(ModifierData *md, ModifierData *target) + +static void copyData(const ModifierData *md, ModifierData *target) { #if 0 - ParticleSystemModifierData *psmd = (ParticleSystemModifierData *) md; + const ParticleSystemModifierData *psmd = (const ParticleSystemModifierData *) md; #endif ParticleSystemModifierData *tpsmd = (ParticleSystemModifierData *) target; diff --git a/source/blender/modifiers/intern/MOD_remesh.c b/source/blender/modifiers/intern/MOD_remesh.c index b85898c07e9..b72c61cfc32 100644 --- a/source/blender/modifiers/intern/MOD_remesh.c +++ b/source/blender/modifiers/intern/MOD_remesh.c @@ -59,15 +59,6 @@ static void initData(ModifierData *md) rmd->threshold = 1; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - RemeshModifierData *rmd = (RemeshModifierData *) md; - RemeshModifierData *trmd = (RemeshModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - #ifdef WITH_MOD_REMESH static void init_dualcon_mesh(DualConInput *mesh, DerivedMesh *dm) @@ -220,7 +211,7 @@ ModifierTypeInfo modifierType_Remesh = { /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_AcceptsCVs | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_screw.c b/source/blender/modifiers/intern/MOD_screw.c index 047b1d5c47d..ec6e0d9a2f4 100644 --- a/source/blender/modifiers/intern/MOD_screw.c +++ b/source/blender/modifiers/intern/MOD_screw.c @@ -176,15 +176,6 @@ static void initData(ModifierData *md) ltmd->merge_dist = 0.01f; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - ScrewModifierData *sltmd = (ScrewModifierData *) md; - ScrewModifierData *tltmd = (ScrewModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static DerivedMesh *applyModifier(ModifierData *md, Object *ob, DerivedMesh *derivedData, ModifierApplyFlag flag) @@ -1160,7 +1151,7 @@ ModifierTypeInfo modifierType_Screw = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_shrinkwrap.c b/source/blender/modifiers/intern/MOD_shrinkwrap.c index e0f48ae5a2f..5dac420cace 100644 --- a/source/blender/modifiers/intern/MOD_shrinkwrap.c +++ b/source/blender/modifiers/intern/MOD_shrinkwrap.c @@ -63,15 +63,6 @@ static void initData(ModifierData *md) smd->auxTarget = NULL; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - ShrinkwrapModifierData *smd = (ShrinkwrapModifierData *)md; - ShrinkwrapModifierData *tsmd = (ShrinkwrapModifierData *)target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { ShrinkwrapModifierData *smd = (ShrinkwrapModifierData *)md; @@ -190,7 +181,7 @@ ModifierTypeInfo modifierType_Shrinkwrap = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_simpledeform.c b/source/blender/modifiers/intern/MOD_simpledeform.c index 71109922f11..6c6518952d6 100644 --- a/source/blender/modifiers/intern/MOD_simpledeform.c +++ b/source/blender/modifiers/intern/MOD_simpledeform.c @@ -349,15 +349,6 @@ static void initData(ModifierData *md) smd->limit[1] = 1.0f; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - SimpleDeformModifierData *smd = (SimpleDeformModifierData *)md; - SimpleDeformModifierData *tsmd = (SimpleDeformModifierData *)target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { SimpleDeformModifierData *smd = (SimpleDeformModifierData *)md; @@ -447,7 +438,7 @@ ModifierTypeInfo modifierType_SimpleDeform = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_skin.c b/source/blender/modifiers/intern/MOD_skin.c index dda0c413f57..5335ad8aeaa 100644 --- a/source/blender/modifiers/intern/MOD_skin.c +++ b/source/blender/modifiers/intern/MOD_skin.c @@ -1907,15 +1907,6 @@ static void initData(ModifierData *md) smd->symmetry_axes = MOD_SKIN_SYMM_X; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - SkinModifierData *smd = (SkinModifierData *) md; - SkinModifierData *tsmd = (SkinModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static DerivedMesh *applyModifier(ModifierData *md, Object *UNUSED(ob), DerivedMesh *dm, @@ -1941,7 +1932,7 @@ ModifierTypeInfo modifierType_Skin = { /* type */ eModifierTypeType_Constructive, /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_smoke.c b/source/blender/modifiers/intern/MOD_smoke.c index 2073e23b7b2..cd179f71d3c 100644 --- a/source/blender/modifiers/intern/MOD_smoke.c +++ b/source/blender/modifiers/intern/MOD_smoke.c @@ -68,9 +68,9 @@ static void initData(ModifierData *md) smd->time = -1; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - SmokeModifierData *smd = (SmokeModifierData *)md; + const SmokeModifierData *smd = (const SmokeModifierData *)md; SmokeModifierData *tsmd = (SmokeModifierData *)target; smokeModifier_copy(smd, tsmd); diff --git a/source/blender/modifiers/intern/MOD_smooth.c b/source/blender/modifiers/intern/MOD_smooth.c index 92025512f02..aa477fd0da5 100644 --- a/source/blender/modifiers/intern/MOD_smooth.c +++ b/source/blender/modifiers/intern/MOD_smooth.c @@ -58,15 +58,6 @@ static void initData(ModifierData *md) smd->defgrp_name[0] = '\0'; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - SmoothModifierData *smd = (SmoothModifierData *) md; - SmoothModifierData *tsmd = (SmoothModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static bool isDisabled(ModifierData *md, int UNUSED(useRenderParams)) { SmoothModifierData *smd = (SmoothModifierData *) md; @@ -250,7 +241,7 @@ ModifierTypeInfo modifierType_Smooth = { eModifierTypeFlag_AcceptsCVs | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_solidify.c b/source/blender/modifiers/intern/MOD_solidify.c index 280f3c771ed..572898c1982 100644 --- a/source/blender/modifiers/intern/MOD_solidify.c +++ b/source/blender/modifiers/intern/MOD_solidify.c @@ -176,15 +176,6 @@ static void initData(ModifierData *md) smd->flag = MOD_SOLIDIFY_RIM; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - SolidifyModifierData *smd = (SolidifyModifierData *) md; - SolidifyModifierData *tsmd = (SolidifyModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { SolidifyModifierData *smd = (SolidifyModifierData *) md; @@ -963,7 +954,7 @@ ModifierTypeInfo modifierType_Solidify = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_subsurf.c b/source/blender/modifiers/intern/MOD_subsurf.c index 288c684269e..4cef4ac8a53 100644 --- a/source/blender/modifiers/intern/MOD_subsurf.c +++ b/source/blender/modifiers/intern/MOD_subsurf.c @@ -63,17 +63,16 @@ static void initData(ModifierData *md) smd->flags |= eSubsurfModifierFlag_SubsurfUv; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { #if 0 - SubsurfModifierData *smd = (SubsurfModifierData *) md; + const SubsurfModifierData *smd = (const SubsurfModifierData *) md; #endif SubsurfModifierData *tsmd = (SubsurfModifierData *) target; modifier_copyData_generic(md, target); tsmd->emCache = tsmd->mCache = NULL; - } static void freeData(ModifierData *md) diff --git a/source/blender/modifiers/intern/MOD_surfacedeform.c b/source/blender/modifiers/intern/MOD_surfacedeform.c index 9abb9e3fe72..0c859dec122 100644 --- a/source/blender/modifiers/intern/MOD_surfacedeform.c +++ b/source/blender/modifiers/intern/MOD_surfacedeform.c @@ -132,9 +132,9 @@ static void freeData(ModifierData *md) } } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - SurfaceDeformModifierData *smd = (SurfaceDeformModifierData *)md; + const SurfaceDeformModifierData *smd = (const SurfaceDeformModifierData *)md; SurfaceDeformModifierData *tsmd = (SurfaceDeformModifierData *)target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_triangulate.c b/source/blender/modifiers/intern/MOD_triangulate.c index b057d6d5a86..d4d94199db6 100644 --- a/source/blender/modifiers/intern/MOD_triangulate.c +++ b/source/blender/modifiers/intern/MOD_triangulate.c @@ -74,16 +74,6 @@ static void initData(ModifierData *md) tmd->ngon_method = MOD_TRIANGULATE_NGON_BEAUTY; } - -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - TriangulateModifierData *smd = (TriangulateModifierData *) md; - TriangulateModifierData *tsmd = (TriangulateModifierData *) target; -#endif - modifier_copyData_generic(md, target); -} - static DerivedMesh *applyModifier(ModifierData *md, Object *UNUSED(ob), DerivedMesh *dm, @@ -109,7 +99,7 @@ ModifierTypeInfo modifierType_Triangulate = { eModifierTypeFlag_EnableInEditmode | eModifierTypeFlag_AcceptsCVs, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_uvproject.c b/source/blender/modifiers/intern/MOD_uvproject.c index 1cefb07b50a..c0e3b488c2e 100644 --- a/source/blender/modifiers/intern/MOD_uvproject.c +++ b/source/blender/modifiers/intern/MOD_uvproject.c @@ -67,10 +67,10 @@ static void initData(ModifierData *md) umd->scalex = umd->scaley = 1.0f; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { #if 0 - UVProjectModifierData *umd = (UVProjectModifierData *) md; + const UVProjectModifierData *umd = (const UVProjectModifierData *) md; #endif UVProjectModifierData *tumd = (UVProjectModifierData *) target; diff --git a/source/blender/modifiers/intern/MOD_uvwarp.c b/source/blender/modifiers/intern/MOD_uvwarp.c index 384efc74666..6d44e31a1f4 100644 --- a/source/blender/modifiers/intern/MOD_uvwarp.c +++ b/source/blender/modifiers/intern/MOD_uvwarp.c @@ -67,15 +67,6 @@ static void initData(ModifierData *md) copy_v2_fl(umd->center, 0.5f); } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - UVWarpModifierData *umd = (UVWarpModifierData *)md; - UVWarpModifierData *tumd = (UVWarpModifierData *)target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { UVWarpModifierData *umd = (UVWarpModifierData *)md; @@ -283,7 +274,7 @@ ModifierTypeInfo modifierType_UVWarp = { /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_warp.c b/source/blender/modifiers/intern/MOD_warp.c index a22120d7b3d..73f6ccc96ed 100644 --- a/source/blender/modifiers/intern/MOD_warp.c +++ b/source/blender/modifiers/intern/MOD_warp.c @@ -61,9 +61,9 @@ static void initData(ModifierData *md) wmd->flag = 0; } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - WarpModifierData *wmd = (WarpModifierData *) md; + const WarpModifierData *wmd = (const WarpModifierData *) md; WarpModifierData *twmd = (WarpModifierData *) target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_wave.c b/source/blender/modifiers/intern/MOD_wave.c index 8fe29c78486..49dd4718c9c 100644 --- a/source/blender/modifiers/intern/MOD_wave.c +++ b/source/blender/modifiers/intern/MOD_wave.c @@ -78,16 +78,6 @@ static void initData(ModifierData *md) wmd->defgrp_name[0] = 0; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - WaveModifierData *wmd = (WaveModifierData *) md; - WaveModifierData *twmd = (WaveModifierData *) target; -#endif - - modifier_copyData_generic(md, target); -} - static bool dependsOnTime(ModifierData *UNUSED(md)) { return true; @@ -366,7 +356,7 @@ ModifierTypeInfo modifierType_Wave = { /* flags */ eModifierTypeFlag_AcceptsCVs | eModifierTypeFlag_AcceptsLattice | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ deformVerts, /* deformMatrices */ NULL, /* deformVertsEM */ deformVertsEM, diff --git a/source/blender/modifiers/intern/MOD_weightvgedit.c b/source/blender/modifiers/intern/MOD_weightvgedit.c index 8d77747b45d..bf9356aaff3 100644 --- a/source/blender/modifiers/intern/MOD_weightvgedit.c +++ b/source/blender/modifiers/intern/MOD_weightvgedit.c @@ -81,9 +81,9 @@ static void freeData(ModifierData *md) curvemapping_free(wmd->cmap_curve); } -static void copyData(ModifierData *md, ModifierData *target) +static void copyData(const ModifierData *md, ModifierData *target) { - WeightVGEditModifierData *wmd = (WeightVGEditModifierData *) md; + const WeightVGEditModifierData *wmd = (const WeightVGEditModifierData *) md; WeightVGEditModifierData *twmd = (WeightVGEditModifierData *) target; modifier_copyData_generic(md, target); diff --git a/source/blender/modifiers/intern/MOD_weightvgmix.c b/source/blender/modifiers/intern/MOD_weightvgmix.c index bd1f58e7d5e..fbd1b0b0976 100644 --- a/source/blender/modifiers/intern/MOD_weightvgmix.c +++ b/source/blender/modifiers/intern/MOD_weightvgmix.c @@ -126,16 +126,6 @@ static void initData(ModifierData *md) wmd->mask_tex_mapping = MOD_DISP_MAP_LOCAL; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - WeightVGMixModifierData *wmd = (WeightVGMixModifierData *) md; - WeightVGMixModifierData *twmd = (WeightVGMixModifierData *) target; -#endif - - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { WeightVGMixModifierData *wmd = (WeightVGMixModifierData *) md; @@ -410,7 +400,7 @@ ModifierTypeInfo modifierType_WeightVGMix = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_UsesPreview, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_weightvgproximity.c b/source/blender/modifiers/intern/MOD_weightvgproximity.c index 2b17efe7b24..e625a63b9cd 100644 --- a/source/blender/modifiers/intern/MOD_weightvgproximity.c +++ b/source/blender/modifiers/intern/MOD_weightvgproximity.c @@ -286,16 +286,6 @@ static void initData(ModifierData *md) wmd->max_dist = 1.0f; /* vert arbitrary distance, but don't use 0 */ } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - WeightVGProximityModifierData *wmd = (WeightVGProximityModifierData *) md; - WeightVGProximityModifierData *twmd = (WeightVGProximityModifierData *) target; -#endif - - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { WeightVGProximityModifierData *wmd = (WeightVGProximityModifierData *) md; @@ -599,7 +589,7 @@ ModifierTypeInfo modifierType_WeightVGProximity = { eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_UsesPreview, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL, diff --git a/source/blender/modifiers/intern/MOD_wireframe.c b/source/blender/modifiers/intern/MOD_wireframe.c index 15f8b185a3d..84a507cd35c 100644 --- a/source/blender/modifiers/intern/MOD_wireframe.c +++ b/source/blender/modifiers/intern/MOD_wireframe.c @@ -43,15 +43,6 @@ static void initData(ModifierData *md) wmd->crease_weight = 1.0f; } -static void copyData(ModifierData *md, ModifierData *target) -{ -#if 0 - WireframeModifierData *wmd = (WireframeModifierData *)md; - WireframeModifierData *twmd = (WireframeModifierData *)target; -#endif - modifier_copyData_generic(md, target); -} - static CustomDataMask requiredDataMask(Object *UNUSED(ob), ModifierData *md) { WireframeModifierData *wmd = (WireframeModifierData *)md; @@ -116,7 +107,7 @@ ModifierTypeInfo modifierType_Wireframe = { /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsEditmode, - /* copyData */ copyData, + /* copyData */ modifier_copyData_generic, /* deformVerts */ NULL, /* deformMatrices */ NULL, /* deformVertsEM */ NULL,