tmaq
/
tornavis
1
0
Fork 0
Code Issues 2 Pull Requests 29 Packages Projects 24 Releases Wiki Activity

Cleanup: Use accessor functions for point cloud positions

This commit is contained in:
Hans Goudey 2023-12-20 13:16:41 -05:00
parent 19001c9e6c
commit 7f24972911
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/blender/editors/object/object_transform.cc
View File

@ -958,11 +958,8 @@ static int apply_objects_internal(bContext *C,
}
else if (ob->type == OB_POINTCLOUD) {
PointCloud &pointcloud = *static_cast<PointCloud *>(ob->data);
bke::MutableAttributeAccessor attributes = pointcloud.attributes_for_write();
bke::SpanAttributeWriter position = attributes.lookup_or_add_for_write_span<float3>(
"position", bke::AttrDomain::Point);
transform_positions(position.span, float4x4(mat));
position.finish();
transform_positions(pointcloud.positions_for_write(), float4x4(mat));
pointcloud.tag_positions_changed();
}
else if (ob->type == OB_CAMERA) {
MovieClip *clip = BKE_object_movieclip_get(scene, ob, false);
@ -1721,9 +1718,7 @@ static int object_origin_set_exec(bContext *C, wmOperator *op)
}
else if (ob->type == OB_POINTCLOUD) {
PointCloud &pointcloud = *static_cast<PointCloud *>(ob->data);
bke::MutableAttributeAccessor attributes = pointcloud.attributes_for_write();
bke::SpanAttributeWriter positions = attributes.lookup_or_add_for_write_span<float3>(
"position", bke::AttrDomain::Point);
MutableSpan<float3> positions = pointcloud.positions_for_write();
if (ELEM(centermode, ORIGIN_TO_CENTER_OF_MASS_SURFACE, ORIGIN_TO_CENTER_OF_MASS_VOLUME) ||
!ELEM(around, V3D_AROUND_CENTER_BOUNDS, V3D_AROUND_CENTER_MEDIAN))
{
@ -1742,12 +1737,12 @@ static int object_origin_set_exec(bContext *C, wmOperator *op)
}
}
else if (around == V3D_AROUND_CENTER_MEDIAN) {
cent = arithmetic_mean(positions.span);
cent = arithmetic_mean(positions);
}
tot_change++;
translate_positions(positions.span, -cent);
positions.finish();
translate_positions(positions, -cent);
pointcloud.tag_positions_changed();
pointcloud.id.tag |= LIB_TAG_DOIT;
do_inverse_offset = true;
}