Cleanup: rename 'filename' & 'str' to 'filepath' for whole file paths

This commit is contained in:
Campbell Barton 2023-05-27 15:10:59 +10:00
parent 823685db76
commit 848a886569
23 changed files with 168 additions and 167 deletions

View File

@ -258,7 +258,7 @@ void BKE_bpath_missing_files_check(Main *bmain, ReportList *reports)
* *
* \param search_directory: Directory to search in. * \param search_directory: Directory to search in.
* \param filename_src: Search for this filename. * \param filename_src: Search for this filename.
* \param r_filename_new: The path of the new found file will be copied here, caller must * \param r_filepath_new: The path of the new found file will be copied here, caller must
* initialize as empty string. * initialize as empty string.
* \param r_filesize: Size of the file, `FILESIZE_INVALID_DIRECTORY` if search directory could not * \param r_filesize: Size of the file, `FILESIZE_INVALID_DIRECTORY` if search directory could not
* be opened. * be opened.
@ -268,7 +268,7 @@ void BKE_bpath_missing_files_check(Main *bmain, ReportList *reports)
*/ */
static bool missing_files_find__recursive(const char *search_directory, static bool missing_files_find__recursive(const char *search_directory,
const char *filename_src, const char *filename_src,
char r_filename_new[FILE_MAX], char r_filepath_new[FILE_MAX],
int64_t *r_filesize, int64_t *r_filesize,
int *r_recurse_depth) int *r_recurse_depth)
{ {
@ -307,7 +307,7 @@ static bool missing_files_find__recursive(const char *search_directory,
size = status.st_size; size = status.st_size;
if ((size > 0) && (size > *r_filesize)) { /* Find the biggest matching file. */ if ((size > 0) && (size > *r_filesize)) { /* Find the biggest matching file. */
*r_filesize = size; *r_filesize = size;
BLI_strncpy(r_filename_new, path, FILE_MAX); BLI_strncpy(r_filepath_new, path, FILE_MAX);
found = true; found = true;
} }
} }
@ -316,7 +316,7 @@ static bool missing_files_find__recursive(const char *search_directory,
if (*r_recurse_depth <= MAX_DIR_RECURSE) { if (*r_recurse_depth <= MAX_DIR_RECURSE) {
(*r_recurse_depth)++; (*r_recurse_depth)++;
found |= missing_files_find__recursive( found |= missing_files_find__recursive(
path, filename_src, r_filename_new, r_filesize, r_recurse_depth); path, filename_src, r_filepath_new, r_filesize, r_recurse_depth);
(*r_recurse_depth)--; (*r_recurse_depth)--;
} }
} }
@ -338,7 +338,7 @@ static bool missing_files_find_foreach_path_cb(BPathForeachPathData *bpath_data,
const char *path_src) const char *path_src)
{ {
BPathFind_Data *data = (BPathFind_Data *)bpath_data->user_data; BPathFind_Data *data = (BPathFind_Data *)bpath_data->user_data;
char filename_new[FILE_MAX]; char filepath_new[FILE_MAX];
int64_t filesize = FILESIZE_INVALID_DIRECTORY; int64_t filesize = FILESIZE_INVALID_DIRECTORY;
int recurse_depth = 0; int recurse_depth = 0;
@ -348,10 +348,10 @@ static bool missing_files_find_foreach_path_cb(BPathForeachPathData *bpath_data,
return false; return false;
} }
filename_new[0] = '\0'; filepath_new[0] = '\0';
is_found = missing_files_find__recursive( is_found = missing_files_find__recursive(
data->searchdir, BLI_path_basename(path_src), filename_new, &filesize, &recurse_depth); data->searchdir, BLI_path_basename(path_src), filepath_new, &filesize, &recurse_depth);
if (filesize == FILESIZE_INVALID_DIRECTORY) { if (filesize == FILESIZE_INVALID_DIRECTORY) {
BKE_reportf(data->reports, BKE_reportf(data->reports,
@ -371,7 +371,7 @@ static bool missing_files_find_foreach_path_cb(BPathForeachPathData *bpath_data,
bool was_relative = BLI_path_is_rel(path_dst); bool was_relative = BLI_path_is_rel(path_dst);
BLI_strncpy(path_dst, filename_new, FILE_MAX); BLI_strncpy(path_dst, filepath_new, FILE_MAX);
/* Keep the path relative if the previous one was relative. */ /* Keep the path relative if the previous one was relative. */
if (was_relative) { if (was_relative) {

View File

@ -601,14 +601,14 @@ static ImBuf *movieclip_load_sequence_file(MovieClip *clip,
static void movieclip_open_anim_file(MovieClip *clip) static void movieclip_open_anim_file(MovieClip *clip)
{ {
char str[FILE_MAX]; char filepath_abs[FILE_MAX];
if (!clip->anim) { if (!clip->anim) {
STRNCPY(str, clip->filepath); STRNCPY(filepath_abs, clip->filepath);
BLI_path_abs(str, ID_BLEND_PATH_FROM_GLOBAL(&clip->id)); BLI_path_abs(filepath_abs, ID_BLEND_PATH_FROM_GLOBAL(&clip->id));
/* FIXME: make several stream accessible in image editor, too */ /* FIXME: make several stream accessible in image editor, too */
clip->anim = openanim(str, IB_rect, 0, clip->colorspace_settings.name); clip->anim = openanim(filepath_abs, IB_rect, 0, clip->colorspace_settings.name);
if (clip->anim) { if (clip->anim) {
if (clip->flag & MCLIP_USE_PROXY_CUSTOM_DIR) { if (clip->flag & MCLIP_USE_PROXY_CUSTOM_DIR) {
@ -968,13 +968,13 @@ MovieClip *BKE_movieclip_file_add(Main *bmain, const char *filepath)
{ {
MovieClip *clip; MovieClip *clip;
int file; int file;
char str[FILE_MAX]; char filepath_abs[FILE_MAX];
STRNCPY(str, filepath); STRNCPY(filepath_abs, filepath);
BLI_path_abs(str, BKE_main_blendfile_path(bmain)); BLI_path_abs(filepath_abs, BKE_main_blendfile_path(bmain));
/* exists? */ /* exists? */
file = BLI_open(str, O_BINARY | O_RDONLY, 0); file = BLI_open(filepath_abs, O_BINARY | O_RDONLY, 0);
if (file == -1) { if (file == -1) {
return NULL; return NULL;
} }
@ -1003,17 +1003,17 @@ MovieClip *BKE_movieclip_file_add(Main *bmain, const char *filepath)
MovieClip *BKE_movieclip_file_add_exists_ex(Main *bmain, const char *filepath, bool *r_exists) MovieClip *BKE_movieclip_file_add_exists_ex(Main *bmain, const char *filepath, bool *r_exists)
{ {
MovieClip *clip; MovieClip *clip;
char str[FILE_MAX], strtest[FILE_MAX]; char filepath_abs[FILE_MAX], filepath_test[FILE_MAX];
STRNCPY(str, filepath); STRNCPY(filepath_abs, filepath);
BLI_path_abs(str, BKE_main_blendfile_path(bmain)); BLI_path_abs(filepath_abs, BKE_main_blendfile_path(bmain));
/* first search an identical filepath */ /* first search an identical filepath */
for (clip = bmain->movieclips.first; clip; clip = clip->id.next) { for (clip = bmain->movieclips.first; clip; clip = clip->id.next) {
STRNCPY(strtest, clip->filepath); STRNCPY(filepath_test, clip->filepath);
BLI_path_abs(strtest, ID_BLEND_PATH(bmain, &clip->id)); BLI_path_abs(filepath_test, ID_BLEND_PATH(bmain, &clip->id));
if (BLI_path_cmp(strtest, str) == 0) { if (BLI_path_cmp(filepath_test, filepath_abs) == 0) {
id_us_plus(&clip->id); /* officially should not, it doesn't link here! */ id_us_plus(&clip->id); /* officially should not, it doesn't link here! */
if (r_exists) { if (r_exists) {
*r_exists = true; *r_exists = true;

View File

@ -1309,15 +1309,15 @@ static int ptcache_path(PTCacheID *pid, char dirname[MAX_PTCACHE_PATH])
{ {
const char *blendfile_path = BKE_main_blendfile_path_from_global(); const char *blendfile_path = BKE_main_blendfile_path_from_global();
Library *lib = (pid->owner_id) ? pid->owner_id->lib : NULL; Library *lib = (pid->owner_id) ? pid->owner_id->lib : NULL;
const char *blendfilename = (lib && (pid->cache->flag & PTCACHE_IGNORE_LIBPATH) == 0) ? const char *blendfile_path_lib = (lib && (pid->cache->flag & PTCACHE_IGNORE_LIBPATH) == 0) ?
lib->filepath_abs : lib->filepath_abs :
blendfile_path; blendfile_path;
if (pid->cache->flag & PTCACHE_EXTERNAL) { if (pid->cache->flag & PTCACHE_EXTERNAL) {
BLI_strncpy(dirname, pid->cache->path, MAX_PTCACHE_PATH); BLI_strncpy(dirname, pid->cache->path, MAX_PTCACHE_PATH);
if (BLI_path_is_rel(dirname)) { if (BLI_path_is_rel(dirname)) {
BLI_path_abs(dirname, blendfilename); BLI_path_abs(dirname, blendfile_path_lib);
} }
return BLI_path_slash_ensure(dirname, MAX_PTCACHE_PATH); /* new strlen() */ return BLI_path_slash_ensure(dirname, MAX_PTCACHE_PATH); /* new strlen() */
@ -1325,14 +1325,14 @@ static int ptcache_path(PTCacheID *pid, char dirname[MAX_PTCACHE_PATH])
if ((blendfile_path[0] != '\0') || lib) { if ((blendfile_path[0] != '\0') || lib) {
char file[MAX_PTCACHE_PATH]; /* we don't want the dir, only the file */ char file[MAX_PTCACHE_PATH]; /* we don't want the dir, only the file */
BLI_path_split_file_part(blendfilename, file, sizeof(file)); BLI_path_split_file_part(blendfile_path_lib, file, sizeof(file));
/* Remove the `.blend` extension. */ /* Remove the `.blend` extension. */
BLI_path_extension_strip(file); BLI_path_extension_strip(file);
/* Add blend file name to pointcache dir. */ /* Add blend file name to pointcache dir. */
BLI_snprintf(dirname, MAX_PTCACHE_PATH, "//" PTCACHE_PATH "%s", file); BLI_snprintf(dirname, MAX_PTCACHE_PATH, "//" PTCACHE_PATH "%s", file);
BLI_path_abs(dirname, blendfilename); BLI_path_abs(dirname, blendfile_path_lib);
return BLI_path_slash_ensure(dirname, MAX_PTCACHE_PATH); /* new strlen() */ return BLI_path_slash_ensure(dirname, MAX_PTCACHE_PATH); /* new strlen() */
} }

View File

@ -256,10 +256,10 @@ bSound *BKE_sound_new_file(Main *bmain, const char *filepath)
{ {
bSound *sound; bSound *sound;
const char *blendfile_path = BKE_main_blendfile_path(bmain); const char *blendfile_path = BKE_main_blendfile_path(bmain);
char str[FILE_MAX]; char filepath_abs[FILE_MAX];
STRNCPY(str, filepath); STRNCPY(filepath_abs, filepath);
BLI_path_abs(str, blendfile_path); BLI_path_abs(filepath_abs, blendfile_path);
sound = BKE_libblock_alloc(bmain, ID_SO, BLI_path_basename(filepath), 0); sound = BKE_libblock_alloc(bmain, ID_SO, BLI_path_basename(filepath), 0);
STRNCPY(sound->filepath, filepath); STRNCPY(sound->filepath, filepath);
@ -284,17 +284,17 @@ bSound *BKE_sound_new_file(Main *bmain, const char *filepath)
bSound *BKE_sound_new_file_exists_ex(Main *bmain, const char *filepath, bool *r_exists) bSound *BKE_sound_new_file_exists_ex(Main *bmain, const char *filepath, bool *r_exists)
{ {
bSound *sound; bSound *sound;
char str[FILE_MAX], strtest[FILE_MAX]; char filepath_abs[FILE_MAX], filepath_test[FILE_MAX];
STRNCPY(str, filepath); STRNCPY(filepath_abs, filepath);
BLI_path_abs(str, BKE_main_blendfile_path(bmain)); BLI_path_abs(filepath_abs, BKE_main_blendfile_path(bmain));
/* first search an identical filepath */ /* first search an identical filepath */
for (sound = bmain->sounds.first; sound; sound = sound->id.next) { for (sound = bmain->sounds.first; sound; sound = sound->id.next) {
STRNCPY(strtest, sound->filepath); STRNCPY(filepath_test, sound->filepath);
BLI_path_abs(strtest, ID_BLEND_PATH(bmain, &sound->id)); BLI_path_abs(filepath_test, ID_BLEND_PATH(bmain, &sound->id));
if (BLI_path_cmp(strtest, str) == 0) { if (BLI_path_cmp(filepath_test, filepath_abs) == 0) {
id_us_plus(&sound->id); /* officially should not, it doesn't link here! */ id_us_plus(&sound->id); /* officially should not, it doesn't link here! */
if (r_exists) { if (r_exists) {
*r_exists = true; *r_exists = true;
@ -1258,15 +1258,15 @@ bool BKE_sound_stream_info_get(struct Main *main,
SoundStreamInfo *sound_info) SoundStreamInfo *sound_info)
{ {
const char *blendfile_path = BKE_main_blendfile_path(main); const char *blendfile_path = BKE_main_blendfile_path(main);
char str[FILE_MAX]; char filepath_abs[FILE_MAX];
AUD_Sound *sound; AUD_Sound *sound;
AUD_StreamInfo *stream_infos; AUD_StreamInfo *stream_infos;
int stream_count; int stream_count;
STRNCPY(str, filepath); STRNCPY(filepath_abs, filepath);
BLI_path_abs(str, blendfile_path); BLI_path_abs(filepath_abs, blendfile_path);
sound = AUD_Sound_file(str); sound = AUD_Sound_file(filepath_abs);
if (!sound) { if (!sound) {
return false; return false;
} }

View File

@ -366,17 +366,17 @@ VFont *BKE_vfont_load(Main *bmain, const char *filepath)
VFont *BKE_vfont_load_exists_ex(struct Main *bmain, const char *filepath, bool *r_exists) VFont *BKE_vfont_load_exists_ex(struct Main *bmain, const char *filepath, bool *r_exists)
{ {
VFont *vfont; VFont *vfont;
char str[FILE_MAX], strtest[FILE_MAX]; char filepath_abs[FILE_MAX], filepath_test[FILE_MAX];
STRNCPY(str, filepath); STRNCPY(filepath_abs, filepath);
BLI_path_abs(str, BKE_main_blendfile_path(bmain)); BLI_path_abs(filepath_abs, BKE_main_blendfile_path(bmain));
/* first search an identical filepath */ /* first search an identical filepath */
for (vfont = bmain->fonts.first; vfont; vfont = vfont->id.next) { for (vfont = bmain->fonts.first; vfont; vfont = vfont->id.next) {
STRNCPY(strtest, vfont->filepath); STRNCPY(filepath_test, vfont->filepath);
BLI_path_abs(strtest, ID_BLEND_PATH(bmain, &vfont->id)); BLI_path_abs(filepath_test, ID_BLEND_PATH(bmain, &vfont->id));
if (BLI_path_cmp(strtest, str) == 0) { if (BLI_path_cmp(filepath_test, filepath_abs) == 0) {
id_us_plus(&vfont->id); /* officially should not, it doesn't link here! */ id_us_plus(&vfont->id); /* officially should not, it doesn't link here! */
if (r_exists) { if (r_exists) {
*r_exists = true; *r_exists = true;

View File

@ -1358,7 +1358,7 @@ static void flush_ffmpeg(AVCodecContext *c, AVStream *stream, AVFormatContext *o
/* Get the output filename-- similar to the other output formats */ /* Get the output filename-- similar to the other output formats */
static void ffmpeg_filepath_get(FFMpegContext *context, static void ffmpeg_filepath_get(FFMpegContext *context,
char string[FILE_MAX], char filepath[FILE_MAX],
const RenderData *rd, const RenderData *rd,
bool preview, bool preview,
const char *suffix) const char *suffix)
@ -1369,7 +1369,7 @@ static void ffmpeg_filepath_get(FFMpegContext *context,
const char **fe = exts; const char **fe = exts;
int sfra, efra; int sfra, efra;
if (!string || !exts) { if (!filepath || !exts) {
return; return;
} }
@ -1382,10 +1382,10 @@ static void ffmpeg_filepath_get(FFMpegContext *context,
efra = rd->efra; efra = rd->efra;
} }
BLI_strncpy(string, rd->pic, FILE_MAX); BLI_strncpy(filepath, rd->pic, FILE_MAX);
BLI_path_abs(string, BKE_main_blendfile_path_from_global()); BLI_path_abs(filepath, BKE_main_blendfile_path_from_global());
BLI_file_ensure_parent_dir_exists(string); BLI_file_ensure_parent_dir_exists(filepath);
autosplit[0] = '\0'; autosplit[0] = '\0';
@ -1397,33 +1397,33 @@ static void ffmpeg_filepath_get(FFMpegContext *context,
if (rd->scemode & R_EXTENSION) { if (rd->scemode & R_EXTENSION) {
while (*fe) { while (*fe) {
if (BLI_strcasecmp(string + strlen(string) - strlen(*fe), *fe) == 0) { if (BLI_strcasecmp(filepath + strlen(filepath) - strlen(*fe), *fe) == 0) {
break; break;
} }
fe++; fe++;
} }
if (*fe == NULL) { if (*fe == NULL) {
BLI_strncat(string, autosplit, FILE_MAX); BLI_strncat(filepath, autosplit, FILE_MAX);
BLI_path_frame_range(string, FILE_MAX, sfra, efra, 4); BLI_path_frame_range(filepath, FILE_MAX, sfra, efra, 4);
BLI_strncat(string, *exts, FILE_MAX); BLI_strncat(filepath, *exts, FILE_MAX);
} }
else { else {
*(string + strlen(string) - strlen(*fe)) = '\0'; *(filepath + strlen(filepath) - strlen(*fe)) = '\0';
BLI_strncat(string, autosplit, FILE_MAX); BLI_strncat(filepath, autosplit, FILE_MAX);
BLI_strncat(string, *fe, FILE_MAX); BLI_strncat(filepath, *fe, FILE_MAX);
} }
} }
else { else {
if (BLI_path_frame_check_chars(string)) { if (BLI_path_frame_check_chars(filepath)) {
BLI_path_frame_range(string, FILE_MAX, sfra, efra, 4); BLI_path_frame_range(filepath, FILE_MAX, sfra, efra, 4);
} }
BLI_strncat(string, autosplit, FILE_MAX); BLI_strncat(filepath, autosplit, FILE_MAX);
} }
BLI_path_suffix(string, FILE_MAX, suffix, ""); BLI_path_suffix(filepath, FILE_MAX, suffix, "");
} }
void BKE_ffmpeg_filepath_get(char *filepath, void BKE_ffmpeg_filepath_get(char *filepath,

View File

@ -631,10 +631,11 @@ static bool seq_sound_proxy_update_cb(Sequence *seq, void *user_data)
{ {
Main *bmain = (Main *)user_data; Main *bmain = (Main *)user_data;
if (seq->type == SEQ_TYPE_SOUND_HD) { if (seq->type == SEQ_TYPE_SOUND_HD) {
char str[FILE_MAX]; char filepath_abs[FILE_MAX];
BLI_path_join(str, sizeof(str), seq->strip->dirpath, seq->strip->stripdata->filename); BLI_path_join(
BLI_path_abs(str, BKE_main_blendfile_path(bmain)); filepath_abs, sizeof(filepath_abs), seq->strip->dirpath, seq->strip->stripdata->filename);
seq->sound = BKE_sound_new_file(bmain, str); BLI_path_abs(filepath_abs, BKE_main_blendfile_path(bmain));
seq->sound = BKE_sound_new_file(bmain, filepath_abs);
} }
#define SEQ_USE_PROXY_CUSTOM_DIR (1 << 19) #define SEQ_USE_PROXY_CUSTOM_DIR (1 << 19)
#define SEQ_USE_PROXY_CUSTOM_FILE (1 << 21) #define SEQ_USE_PROXY_CUSTOM_FILE (1 << 21)

View File

@ -88,12 +88,12 @@ static int wm_alembic_export_invoke(bContext *C, wmOperator *op, const wmEvent *
static int wm_alembic_export_exec(bContext *C, wmOperator *op) static int wm_alembic_export_exec(bContext *C, wmOperator *op)
{ {
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
char filename[FILE_MAX]; char filepath[FILE_MAX];
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
struct AlembicExportParams params = { struct AlembicExportParams params = {
.frame_start = RNA_int_get(op->ptr, "start"), .frame_start = RNA_int_get(op->ptr, "start"),
@ -139,7 +139,7 @@ static int wm_alembic_export_exec(bContext *C, wmOperator *op)
} }
const bool as_background_job = RNA_boolean_get(op->ptr, "as_background_job"); const bool as_background_job = RNA_boolean_get(op->ptr, "as_background_job");
bool ok = ABC_export(scene, C, filename, &params, as_background_job); bool ok = ABC_export(scene, C, filepath, &params, as_background_job);
return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED; return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED;
} }
@ -493,37 +493,37 @@ static int cmp_frame(const void *a, const void *b)
return 0; return 0;
} }
static int get_sequence_len(const char *filename, int *ofs) static int get_sequence_len(const char *filepath, int *ofs)
{ {
int frame; int frame;
int numdigit; int numdigit;
if (!BLI_path_frame_get(filename, &frame, &numdigit)) { if (!BLI_path_frame_get(filepath, &frame, &numdigit)) {
return 1; return 1;
} }
char path[FILE_MAX]; char dirpath[FILE_MAX];
BLI_path_split_dir_part(filename, path, FILE_MAX); BLI_path_split_dir_part(filepath, dirpath, FILE_MAX);
if (path[0] == '\0') { if (dirpath[0] == '\0') {
/* The filename had no path, so just use the blend file path. */ /* The `filepath` had no directory component, so just use the blend files directory. */
BLI_path_split_dir_part(BKE_main_blendfile_path_from_global(), path, FILE_MAX); BLI_path_split_dir_part(BKE_main_blendfile_path_from_global(), dirpath, sizeof(dirpath));
} }
else { else {
BLI_path_abs(path, BKE_main_blendfile_path_from_global()); BLI_path_abs(dirpath, BKE_main_blendfile_path_from_global());
} }
DIR *dir = opendir(path); DIR *dir = opendir(dirpath);
if (dir == NULL) { if (dir == NULL) {
fprintf(stderr, fprintf(stderr,
"Error opening directory '%s': %s\n", "Error opening directory '%s': %s\n",
path, dirpath,
errno ? strerror(errno) : "unknown error"); errno ? strerror(errno) : "unknown error");
return -1; return -1;
} }
const char *ext = ".abc"; const char *ext = ".abc";
const char *basename = BLI_path_basename(filename); const char *basename = BLI_path_basename(filepath);
const int len = strlen(basename) - (numdigit + strlen(ext)); const int len = strlen(basename) - (numdigit + strlen(ext));
ListBase frames; ListBase frames;
@ -613,12 +613,12 @@ static int wm_alembic_import_invoke(bContext *C, wmOperator *op, const wmEvent *
static int wm_alembic_import_exec(bContext *C, wmOperator *op) static int wm_alembic_import_exec(bContext *C, wmOperator *op)
{ {
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
char filename[FILE_MAX]; char filepath[FILE_MAX];
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
const float scale = RNA_float_get(op->ptr, "scale"); const float scale = RNA_float_get(op->ptr, "scale");
const bool is_sequence = RNA_boolean_get(op->ptr, "is_sequence"); const bool is_sequence = RNA_boolean_get(op->ptr, "is_sequence");
@ -631,7 +631,7 @@ static int wm_alembic_import_exec(bContext *C, wmOperator *op)
int sequence_len = 1; int sequence_len = 1;
if (is_sequence) { if (is_sequence) {
sequence_len = get_sequence_len(filename, &offset); sequence_len = get_sequence_len(filepath, &offset);
if (sequence_len < 0) { if (sequence_len < 0) {
BKE_report(op->reports, RPT_ERROR, "Unable to determine ABC sequence length"); BKE_report(op->reports, RPT_ERROR, "Unable to determine ABC sequence length");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
@ -653,7 +653,7 @@ static int wm_alembic_import_exec(bContext *C, wmOperator *op)
params.validate_meshes = validate_meshes; params.validate_meshes = validate_meshes;
params.always_add_cache_reader = always_add_cache_reader; params.always_add_cache_reader = always_add_cache_reader;
bool ok = ABC_import(C, filename, &params, as_background_job); bool ok = ABC_import(C, filepath, &params, as_background_job);
return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED; return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED;
} }

View File

@ -84,7 +84,7 @@ static int wm_collada_export_exec(bContext *C, wmOperator *op)
int sample_animations; int sample_animations;
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
@ -678,7 +678,7 @@ void WM_OT_collada_export(wmOperatorType *ot)
static int wm_collada_import_exec(bContext *C, wmOperator *op) static int wm_collada_import_exec(bContext *C, wmOperator *op)
{ {
char filename[FILE_MAX]; char filepath[FILE_MAX];
int import_units; int import_units;
int find_chains; int find_chains;
int auto_connect; int auto_connect;
@ -690,7 +690,7 @@ static int wm_collada_import_exec(bContext *C, wmOperator *op)
ImportSettings import_settings; ImportSettings import_settings;
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
@ -705,9 +705,9 @@ static int wm_collada_import_exec(bContext *C, wmOperator *op)
min_chain_length = RNA_int_get(op->ptr, "min_chain_length"); min_chain_length = RNA_int_get(op->ptr, "min_chain_length");
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
import_settings.filepath = filename; import_settings.filepath = filepath;
import_settings.import_units = import_units != 0; import_settings.import_units = import_units != 0;
import_settings.custom_normals = custom_normals != 0; import_settings.custom_normals = custom_normals != 0;
import_settings.auto_connect = auto_connect != 0; import_settings.auto_connect = auto_connect != 0;

View File

@ -106,7 +106,7 @@ static int wm_gpencil_export_svg_exec(bContext *C, wmOperator *op)
Object *ob = CTX_data_active_object(C); Object *ob = CTX_data_active_object(C);
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
@ -117,8 +117,8 @@ static int wm_gpencil_export_svg_exec(bContext *C, wmOperator *op)
} }
View3D *v3d = get_invoke_view3d(C); View3D *v3d = get_invoke_view3d(C);
char filename[FILE_MAX]; char filepath[FILE_MAX];
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
const bool use_fill = RNA_boolean_get(op->ptr, "use_fill"); const bool use_fill = RNA_boolean_get(op->ptr, "use_fill");
const bool use_norm_thickness = RNA_boolean_get(op->ptr, "use_normalized_thickness"); const bool use_norm_thickness = RNA_boolean_get(op->ptr, "use_normalized_thickness");
@ -149,7 +149,7 @@ static int wm_gpencil_export_svg_exec(bContext *C, wmOperator *op)
/* Do export. */ /* Do export. */
WM_cursor_wait(true); WM_cursor_wait(true);
const bool done = gpencil_io_export(filename, &params); const bool done = gpencil_io_export(filepath, &params);
WM_cursor_wait(false); WM_cursor_wait(false);
if (!done) { if (!done) {
@ -261,7 +261,7 @@ static int wm_gpencil_export_pdf_exec(bContext *C, wmOperator *op)
Object *ob = CTX_data_active_object(C); Object *ob = CTX_data_active_object(C);
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
@ -272,8 +272,8 @@ static int wm_gpencil_export_pdf_exec(bContext *C, wmOperator *op)
} }
View3D *v3d = get_invoke_view3d(C); View3D *v3d = get_invoke_view3d(C);
char filename[FILE_MAX]; char filepath[FILE_MAX];
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
const bool use_fill = RNA_boolean_get(op->ptr, "use_fill"); const bool use_fill = RNA_boolean_get(op->ptr, "use_fill");
const bool use_norm_thickness = RNA_boolean_get(op->ptr, "use_normalized_thickness"); const bool use_norm_thickness = RNA_boolean_get(op->ptr, "use_normalized_thickness");
@ -302,7 +302,7 @@ static int wm_gpencil_export_pdf_exec(bContext *C, wmOperator *op)
/* Do export. */ /* Do export. */
WM_cursor_wait(true); WM_cursor_wait(true);
const bool done = gpencil_io_export(filename, &params); const bool done = gpencil_io_export(filepath, &params);
WM_cursor_wait(false); WM_cursor_wait(false);
if (!done) { if (!done) {

View File

@ -68,7 +68,7 @@ static int wm_gpencil_import_svg_exec(bContext *C, wmOperator *op)
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false) || if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false) ||
!RNA_struct_find_property(op->ptr, "directory")) !RNA_struct_find_property(op->ptr, "directory"))
{ {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }

View File

@ -68,7 +68,7 @@ static int wm_obj_export_invoke(bContext *C, wmOperator *op, const wmEvent *UNUS
static int wm_obj_export_exec(bContext *C, wmOperator *op) static int wm_obj_export_exec(bContext *C, wmOperator *op)
{ {
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
struct OBJExportParams export_params; struct OBJExportParams export_params;
@ -414,7 +414,7 @@ static int wm_obj_import_exec(bContext *C, wmOperator *op)
OBJ_import(C, &import_params); OBJ_import(C, &import_params);
} }
else { else {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }

View File

@ -61,7 +61,7 @@ static int wm_ply_export_invoke(bContext *C, wmOperator *op, const wmEvent *UNUS
static int wm_ply_export_exec(bContext *C, wmOperator *op) static int wm_ply_export_exec(bContext *C, wmOperator *op)
{ {
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
struct PLYExportParams export_params = {"\0"}; struct PLYExportParams export_params = {"\0"};
@ -259,7 +259,7 @@ static int wm_ply_import_execute(bContext *C, wmOperator *op)
PLY_import(C, &params, op); PLY_import(C, &params, op);
} }
else { else {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }

View File

@ -58,7 +58,7 @@ static int wm_stl_import_execute(bContext *C, wmOperator *op)
STL_import(C, &params); STL_import(C, &params);
} }
else { else {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }

View File

@ -127,12 +127,12 @@ static int wm_usd_export_invoke(bContext *C, wmOperator *op, const wmEvent *UNUS
static int wm_usd_export_exec(bContext *C, wmOperator *op) static int wm_usd_export_exec(bContext *C, wmOperator *op)
{ {
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
char filename[FILE_MAX]; char filepath[FILE_MAX];
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
eUSDOperatorOptions *options = (eUSDOperatorOptions *)op->customdata; eUSDOperatorOptions *options = (eUSDOperatorOptions *)op->customdata;
const bool as_background_job = (options != NULL && options->as_background_job); const bool as_background_job = (options != NULL && options->as_background_job);
@ -175,7 +175,7 @@ static int wm_usd_export_exec(bContext *C, wmOperator *op)
STRNCPY(params.root_prim_path, root_prim_path); STRNCPY(params.root_prim_path, root_prim_path);
bool ok = USD_export(C, filename, &params, as_background_job); bool ok = USD_export(C, filepath, &params, as_background_job);
return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED; return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED;
} }
@ -383,12 +383,12 @@ static int wm_usd_import_invoke(bContext *C, wmOperator *op, const wmEvent *even
static int wm_usd_import_exec(bContext *C, wmOperator *op) static int wm_usd_import_exec(bContext *C, wmOperator *op)
{ {
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }
char filename[FILE_MAX]; char filepath[FILE_MAX];
RNA_string_get(op->ptr, "filepath", filename); RNA_string_get(op->ptr, "filepath", filepath);
eUSDOperatorOptions *options = (eUSDOperatorOptions *)op->customdata; eUSDOperatorOptions *options = (eUSDOperatorOptions *)op->customdata;
const bool as_background_job = (options != NULL && options->as_background_job); const bool as_background_job = (options != NULL && options->as_background_job);
@ -496,7 +496,7 @@ static int wm_usd_import_exec(bContext *C, wmOperator *op)
STRNCPY(params.import_textures_dir, import_textures_dir); STRNCPY(params.import_textures_dir, import_textures_dir);
const bool ok = USD_import(C, filename, &params, as_background_job); const bool ok = USD_import(C, filepath, &params, as_background_job);
return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED; return as_background_job || ok ? OPERATOR_FINISHED : OPERATOR_CANCELLED;
} }

View File

@ -78,11 +78,11 @@ static int volume_import_exec(bContext *C, wmOperator *op)
ListBase ranges = ED_image_filesel_detect_sequences(bmain, op, false); ListBase ranges = ED_image_filesel_detect_sequences(bmain, op, false);
LISTBASE_FOREACH (ImageFrameRange *, range, &ranges) { LISTBASE_FOREACH (ImageFrameRange *, range, &ranges) {
char filename[FILE_MAX]; char filepath[FILE_MAX];
BLI_path_split_file_part(range->filepath, filename, sizeof(filename)); BLI_path_split_file_part(range->filepath, filepath, sizeof(filepath));
BLI_path_extension_strip(filename); BLI_path_extension_strip(filepath);
Object *object = object_volume_add(C, op, filename); Object *object = object_volume_add(C, op, filepath);
Volume *volume = (Volume *)object->data; Volume *volume = (Volume *)object->data;
STRNCPY(volume->filepath, range->filepath); STRNCPY(volume->filepath, range->filepath);
@ -94,7 +94,7 @@ static int volume_import_exec(bContext *C, wmOperator *op)
BKE_reportf(op->reports, BKE_reportf(op->reports,
RPT_WARNING, RPT_WARNING,
"Volume \"%s\" failed to load: %s", "Volume \"%s\" failed to load: %s",
filename, filepath,
BKE_volume_grids_error_msg(volume)); BKE_volume_grids_error_msg(volume));
BKE_id_delete(bmain, &object->id); BKE_id_delete(bmain, &object->id);
BKE_id_delete(bmain, &volume->id); BKE_id_delete(bmain, &volume->id);
@ -104,7 +104,7 @@ static int volume_import_exec(bContext *C, wmOperator *op)
BKE_reportf(op->reports, BKE_reportf(op->reports,
RPT_WARNING, RPT_WARNING,
"Volume \"%s\" contains points, only voxel grids are supported", "Volume \"%s\" contains points, only voxel grids are supported",
filename); filepath);
BKE_id_delete(bmain, &object->id); BKE_id_delete(bmain, &object->id);
BKE_id_delete(bmain, &volume->id); BKE_id_delete(bmain, &volume->id);
continue; continue;

View File

@ -3178,7 +3178,7 @@ static int sequencer_export_subtitles_exec(bContext *C, wmOperator *op)
char filepath[FILE_MAX]; char filepath[FILE_MAX];
if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) { if (!RNA_struct_property_is_set_ex(op->ptr, "filepath", false)) {
BKE_report(op->reports, RPT_ERROR, "No filename given"); BKE_report(op->reports, RPT_ERROR, "No filepath given");
return OPERATOR_CANCELLED; return OPERATOR_CANCELLED;
} }

View File

@ -428,7 +428,7 @@ static bool get_proxy_filepath(struct anim *anim,
return true; return true;
} }
static void get_tc_filename(struct anim *anim, IMB_Timecode_Type tc, char *filepath) static void get_tc_filepath(struct anim *anim, IMB_Timecode_Type tc, char *filepath)
{ {
char index_dir[FILE_MAXDIR]; char index_dir[FILE_MAXDIR];
int i = IMB_timecode_to_array_index(tc); int i = IMB_timecode_to_array_index(tc);
@ -939,7 +939,7 @@ static IndexBuildContext *index_ffmpeg_create_context(struct anim *anim,
if (tcs_in_use & tc_types[i]) { if (tcs_in_use & tc_types[i]) {
char filepath[FILE_MAX]; char filepath[FILE_MAX];
get_tc_filename(anim, tc_types[i], filepath); get_tc_filepath(anim, tc_types[i], filepath);
context->indexer[i] = IMB_index_builder_create(filepath); context->indexer[i] = IMB_index_builder_create(filepath);
if (!context->indexer[i]) { if (!context->indexer[i]) {
@ -1428,17 +1428,17 @@ IndexBuildContext *IMB_anim_index_rebuild_context(struct anim *anim,
for (i = 0; i < IMB_PROXY_MAX_SLOT; i++) { for (i = 0; i < IMB_PROXY_MAX_SLOT; i++) {
IMB_Proxy_Size proxy_size = proxy_sizes[i]; IMB_Proxy_Size proxy_size = proxy_sizes[i];
if (proxy_size & proxy_sizes_to_build) { if (proxy_size & proxy_sizes_to_build) {
char filename[FILE_MAX]; char filepath[FILE_MAX];
if (get_proxy_filepath(anim, proxy_size, filename, false) == false) { if (get_proxy_filepath(anim, proxy_size, filepath, false) == false) {
return nullptr; return nullptr;
} }
void **filename_key_p; void **filepath_key_p;
if (!BLI_gset_ensure_p_ex(file_list, filename, &filename_key_p)) { if (!BLI_gset_ensure_p_ex(file_list, filepath, &filepath_key_p)) {
*filename_key_p = BLI_strdup(filename); *filepath_key_p = BLI_strdup(filepath);
} }
else { else {
proxy_sizes_to_build &= ~int(proxy_size); proxy_sizes_to_build &= ~int(proxy_size);
printf("Proxy: %s already registered for generation, skipping\n", filename); printf("Proxy: %s already registered for generation, skipping\n", filepath);
} }
} }
} }
@ -1451,11 +1451,11 @@ IndexBuildContext *IMB_anim_index_rebuild_context(struct anim *anim,
for (i = 0; i < IMB_PROXY_MAX_SLOT; i++) { for (i = 0; i < IMB_PROXY_MAX_SLOT; i++) {
IMB_Proxy_Size proxy_size = proxy_sizes[i]; IMB_Proxy_Size proxy_size = proxy_sizes[i];
if (proxy_size & built_proxies) { if (proxy_size & built_proxies) {
char filename[FILE_MAX]; char filepath[FILE_MAX];
if (get_proxy_filepath(anim, proxy_size, filename, false) == false) { if (get_proxy_filepath(anim, proxy_size, filepath, false) == false) {
return nullptr; return nullptr;
} }
printf("Skipping proxy: %s\n", filename); printf("Skipping proxy: %s\n", filepath);
} }
} }
} }
@ -1615,7 +1615,7 @@ struct anim_index *IMB_anim_open_index(struct anim *anim, IMB_Timecode_Type tc)
return nullptr; return nullptr;
} }
get_tc_filename(anim, tc, filepath); get_tc_filepath(anim, tc, filepath);
anim->curr_idx[i] = IMB_indexer_open(filepath); anim->curr_idx[i] = IMB_indexer_open(filepath);
@ -1642,9 +1642,9 @@ int IMB_anim_proxy_get_existing(struct anim *anim)
int i; int i;
for (i = 0; i < num_proxy_sizes; i++) { for (i = 0; i < num_proxy_sizes; i++) {
IMB_Proxy_Size proxy_size = proxy_sizes[i]; IMB_Proxy_Size proxy_size = proxy_sizes[i];
char filename[FILE_MAX]; char filepath[FILE_MAX];
get_proxy_filepath(anim, proxy_size, filename, false); get_proxy_filepath(anim, proxy_size, filepath, false);
if (BLI_exists(filename)) { if (BLI_exists(filepath)) {
existing |= int(proxy_size); existing |= int(proxy_size);
} }
} }

View File

@ -65,20 +65,20 @@ static MetaData create_abc_metadata(const Main *bmain, double scene_fps)
} }
static OArchive *create_archive(std::ofstream *abc_ostream, static OArchive *create_archive(std::ofstream *abc_ostream,
const std::string &filename, const std::string &filepath,
MetaData &abc_metadata) MetaData &abc_metadata)
{ {
/* Use stream to support unicode character paths on Windows. */ /* Use stream to support unicode character paths on Windows. */
#ifdef WIN32 #ifdef WIN32
char filename_cstr[FILE_MAX]; char filepath_cstr[FILE_MAX];
BLI_strncpy(filename_cstr, filename.c_str(), FILE_MAX); BLI_strncpy(filepath_cstr, filepath.c_str(), FILE_MAX);
UTF16_ENCODE(filename_cstr); UTF16_ENCODE(filepath_cstr);
std::wstring wstr(filename_cstr_16); std::wstring wstr(filepath_cstr_16);
abc_ostream->open(wstr.c_str(), std::ios::out | std::ios::binary); abc_ostream->open(wstr.c_str(), std::ios::out | std::ios::binary);
UTF16_UN_ENCODE(filename_cstr); UTF16_UN_ENCODE(filepath_cstr);
#else #else
abc_ostream->open(filename, std::ios::out | std::ios::binary); abc_ostream->open(filepath, std::ios::out | std::ios::binary);
#endif #endif
ErrorHandler::Policy policy = ErrorHandler::kThrowPolicy; ErrorHandler::Policy policy = ErrorHandler::kThrowPolicy;
@ -155,14 +155,14 @@ static void get_frames(double scene_fps,
ABCArchive::ABCArchive(const Main *bmain, ABCArchive::ABCArchive(const Main *bmain,
const Scene *scene, const Scene *scene,
AlembicExportParams params, AlembicExportParams params,
std::string filename) std::string filepath)
: archive(nullptr) : archive(nullptr)
{ {
double scene_fps = FPS; double scene_fps = FPS;
MetaData abc_metadata = create_abc_metadata(bmain, scene_fps); MetaData abc_metadata = create_abc_metadata(bmain, scene_fps);
/* Create the Archive. */ /* Create the Archive. */
archive = create_archive(&abc_ostream_, filename, abc_metadata); archive = create_archive(&abc_ostream_, filepath, abc_metadata);
/* Create time samples for transforms and shapes. */ /* Create time samples for transforms and shapes. */
TimeSamplingPtr ts_xform; TimeSamplingPtr ts_xform;

View File

@ -35,7 +35,7 @@ class ABCArchive {
ABCArchive(const Main *bmain, ABCArchive(const Main *bmain,
const Scene *scene, const Scene *scene,
AlembicExportParams params, AlembicExportParams params,
std::string filename); std::string filepath);
~ABCArchive(); ~ABCArchive();
uint32_t time_sampling_index_transforms() const; uint32_t time_sampling_index_transforms() const;

View File

@ -40,7 +40,7 @@ struct ExportJobData {
Depsgraph *depsgraph; Depsgraph *depsgraph;
wmWindowManager *wm; wmWindowManager *wm;
char filename[FILE_MAX]; char filepath[FILE_MAX];
AlembicExportParams params; AlembicExportParams params;
bool was_canceled; bool was_canceled;
@ -64,7 +64,7 @@ static void build_depsgraph(Depsgraph *depsgraph, const bool visible_objects_onl
static void report_job_duration(const ExportJobData *data) static void report_job_duration(const ExportJobData *data)
{ {
blender::timeit::Nanoseconds duration = blender::timeit::Clock::now() - data->start_time; blender::timeit::Nanoseconds duration = blender::timeit::Clock::now() - data->start_time;
std::cout << "Alembic export of '" << data->filename << "' took "; std::cout << "Alembic export of '" << data->filepath << "' took ";
blender::timeit::print_duration(duration); blender::timeit::print_duration(duration);
std::cout << '\n'; std::cout << '\n';
} }
@ -103,11 +103,11 @@ static void export_startjob(void *customdata,
std::unique_ptr<ABCArchive> abc_archive; std::unique_ptr<ABCArchive> abc_archive;
try { try {
abc_archive = std::make_unique<ABCArchive>( abc_archive = std::make_unique<ABCArchive>(
data->bmain, scene, data->params, std::string(data->filename)); data->bmain, scene, data->params, std::string(data->filepath));
} }
catch (const std::exception &ex) { catch (const std::exception &ex) {
std::stringstream error_message_stream; std::stringstream error_message_stream;
error_message_stream << "Error writing to " << data->filename; error_message_stream << "Error writing to " << data->filepath;
const std::string &error_message = error_message_stream.str(); const std::string &error_message = error_message_stream.str();
/* The exception message can be very cryptic (just "iostream error" on Linux, for example), /* The exception message can be very cryptic (just "iostream error" on Linux, for example),
@ -120,7 +120,7 @@ static void export_startjob(void *customdata,
catch (...) { catch (...) {
/* Unknown exception class, so we cannot include its message. */ /* Unknown exception class, so we cannot include its message. */
std::stringstream error_message_stream; std::stringstream error_message_stream;
error_message_stream << "Unknown error writing to " << data->filename; error_message_stream << "Unknown error writing to " << data->filepath;
WM_report(RPT_ERROR, error_message_stream.str().c_str()); WM_report(RPT_ERROR, error_message_stream.str().c_str());
data->export_ok = false; data->export_ok = false;
return; return;
@ -182,8 +182,8 @@ static void export_endjob(void *customdata)
DEG_graph_free(data->depsgraph); DEG_graph_free(data->depsgraph);
if (data->was_canceled && BLI_exists(data->filename)) { if (data->was_canceled && BLI_exists(data->filepath)) {
BLI_delete(data->filename, false, false); BLI_delete(data->filepath, false, false);
} }
G.is_rendering = false; G.is_rendering = false;
@ -207,7 +207,7 @@ bool ABC_export(Scene *scene,
job->bmain = CTX_data_main(C); job->bmain = CTX_data_main(C);
job->wm = CTX_wm_manager(C); job->wm = CTX_wm_manager(C);
job->export_ok = false; job->export_ok = false;
STRNCPY(job->filename, filepath); STRNCPY(job->filepath, filepath);
job->depsgraph = DEG_graph_new(job->bmain, scene, view_layer, params->evaluation_mode); job->depsgraph = DEG_graph_new(job->bmain, scene, view_layer, params->evaluation_mode);
job->params = *params; job->params = *params;

View File

@ -104,22 +104,22 @@ ArchiveReader::ArchiveReader(const std::vector<ArchiveReader *> &readers) : m_re
ArchiveReader::ArchiveReader(struct Main *bmain, const char *filename) ArchiveReader::ArchiveReader(struct Main *bmain, const char *filename)
{ {
char abs_filename[FILE_MAX]; char abs_filepath[FILE_MAX];
STRNCPY(abs_filename, filename); STRNCPY(abs_filepath, filename);
BLI_path_abs(abs_filename, BKE_main_blendfile_path(bmain)); BLI_path_abs(abs_filepath, BKE_main_blendfile_path(bmain));
#ifdef WIN32 #ifdef WIN32
UTF16_ENCODE(abs_filename); UTF16_ENCODE(abs_filepath);
std::wstring wstr(abs_filename_16); std::wstring wstr(abs_filepath_16);
m_infile.open(wstr.c_str(), std::ios::in | std::ios::binary); m_infile.open(wstr.c_str(), std::ios::in | std::ios::binary);
UTF16_UN_ENCODE(abs_filename); UTF16_UN_ENCODE(abs_filepath);
#else #else
m_infile.open(abs_filename, std::ios::in | std::ios::binary); m_infile.open(abs_filepath, std::ios::in | std::ios::binary);
#endif #endif
m_streams.push_back(&m_infile); m_streams.push_back(&m_infile);
m_archive = open_archive(abs_filename, m_streams); m_archive = open_archive(abs_filepath, m_streams);
} }
ArchiveReader::~ArchiveReader() ArchiveReader::~ArchiveReader()

View File

@ -25,7 +25,7 @@ namespace blender::io::usd {
const StringRefNull usdz_export_test_filename = "usd/usdz_export_test.blend"; const StringRefNull usdz_export_test_filename = "usd/usdz_export_test.blend";
char temp_dir[FILE_MAX]; char temp_dir[FILE_MAX];
char temp_output_dir[FILE_MAX]; char temp_output_dir[FILE_MAX];
char output_filename[FILE_MAX]; char output_filepath[FILE_MAX];
class UsdUsdzExportTest : public BlendfileLoadingBaseTest { class UsdUsdzExportTest : public BlendfileLoadingBaseTest {
protected: protected:
@ -64,7 +64,7 @@ class UsdUsdzExportTest : public BlendfileLoadingBaseTest {
BLI_path_join(temp_output_dir, FILE_MAX, temp_base_dir, "usdz_test_output_dir"); BLI_path_join(temp_output_dir, FILE_MAX, temp_base_dir, "usdz_test_output_dir");
BLI_dir_create_recursive(temp_output_dir); BLI_dir_create_recursive(temp_output_dir);
BLI_path_join(output_filename, FILE_MAX, temp_output_dir, "output_новый.usdz"); BLI_path_join(output_filepath, FILE_MAX, temp_output_dir, "output_новый.usdz");
} }
virtual void TearDown() override virtual void TearDown() override
@ -99,10 +99,10 @@ TEST_F(UsdUsdzExportTest, usdz_export)
USDExportParams params{}; USDExportParams params{};
bool result = USD_export(context, output_filename, &params, false); bool result = USD_export(context, output_filepath, &params, false);
ASSERT_TRUE(result) << "usd export to " << output_filename << " failed."; ASSERT_TRUE(result) << "usd export to " << output_filepath << " failed.";
pxr::UsdStageRefPtr stage = pxr::UsdStage::Open(output_filename); pxr::UsdStageRefPtr stage = pxr::UsdStage::Open(output_filepath);
ASSERT_TRUE(bool(stage)) << "unable to open stage for the exported usdz file."; ASSERT_TRUE(bool(stage)) << "unable to open stage for the exported usdz file.";
std::string prim_name = pxr::TfMakeValidIdentifier("Cube"); std::string prim_name = pxr::TfMakeValidIdentifier("Cube");