From af101ad3f810c0ae77696c91cd4bbfae2f0dd012 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Mon, 7 Aug 2023 16:45:49 +0200 Subject: [PATCH] Compositor: Increase tolerance for matte tests The node_keying_matte.blend test is very sensitive to the exact pixel values in the input image. It is hard to match the output between SSE and non-SEE codepaths of sRGB-to-linear conversion, especially when it is done form the OCIO side. Note that even without OCIO the match could be very difficult to achieve, since BLI also implements SSE optimization (although, we are in better control over there, so might increase the accuracy). Ref #110685 Pull Request: https://projects.blender.org/blender/blender/pulls/110897 --- tests/python/compositor_render_tests.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/python/compositor_render_tests.py b/tests/python/compositor_render_tests.py index 5488c3b9bcd..e3d7a0ca1a0 100644 --- a/tests/python/compositor_render_tests.py +++ b/tests/python/compositor_render_tests.py @@ -55,8 +55,14 @@ def main(): report.set_pixelated(True) report.set_reference_dir("compositor_renders") - # Temporary change to pass OpenImageDenoise test with both 1.3 and 1.4. if os.path.basename(test_dir) == 'filter': + # Temporary change to pass OpenImageDenoise test with both 1.3 and 1.4. + report.set_fail_threshold(0.05) + elif os.path.basename(test_dir) == 'matte': + # The node_keying_matte.blend test is very sensitive to the exact values in the + # input image. It makes it hard to precisely match results on different systems + # (with and without SSE, i.e.), especially when OCIO has different precision for + # the exponent transform on different platforms. report.set_fail_threshold(0.05) ok = report.run(test_dir, blender, get_arguments, batch=True)