tmaq
/
tornavis
1
0
Fork 0
Code Issues 2 Pull Requests 29 Packages Projects 24 Releases Wiki Activity

Cleanup: Clang-Tidy readability-static-accessed-through-instance fixes 

No functional changes.
This commit is contained in:
Sybren A. Stüvel 2020-09-04 12:26:24 +02:00
parent 3e3e42cbcb
commit cc2b114a21
6 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy
View File

@ -14,7 +14,6 @@ Checks: >
-readability-inconsistent-declaration-parameter-name,
-readability-redundant-member-init,
-readability-static-accessed-through-instance,
-readability-redundant-declaration,
-readability-qualified-auto,
-readability-use-anyofallof,

2
source/blender/compositor/operations/COM_WriteBufferOperation.cpp
View File

@ -128,7 +128,7 @@ void WriteBufferOperation::executeOpenCLRegion(OpenCLDevice *device,
const unsigned int outputBufferWidth = outputBuffer->getWidth();
const unsigned int outputBufferHeight = outputBuffer->getHeight();
const cl_image_format *imageFormat = device->determineImageFormat(outputBuffer);
const cl_image_format *imageFormat = OpenCLDevice::determineImageFormat(outputBuffer);
cl_mem clOutputBuffer = clCreateImage2D(device->getContext(),
CL_MEM_WRITE_ONLY | CL_MEM_USE_HOST_PTR,

2
source/blender/io/collada/AnimationImporter.cpp
View File

@ -2043,7 +2043,7 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm,
mj = 0;
}
}
unit_converter->dae_matrix_to_mat4_(mat, matrix);
UnitConverter::dae_matrix_to_mat4_(mat, matrix);
return true;
}
}

4
source/blender/io/collada/SkinInfo.cpp
View File

@ -115,7 +115,7 @@ void SkinInfo::borrow_skin_controller_data(const COLLADAFW::SkinControllerData *
weights.push_back(bc_get_float_value(weight, i));
}
unit_converter->dae_matrix_to_mat4_(bind_shape_matrix, skin->getBindShapeMatrix());
UnitConverter::dae_matrix_to_mat4_(bind_shape_matrix, skin->getBindShapeMatrix());
}
void SkinInfo::free()
@ -132,7 +132,7 @@ void SkinInfo::free()
void SkinInfo::add_joint(const COLLADABU::Math::Matrix4 &matrix)
{
JointData jd;
unit_converter->dae_matrix_to_mat4_(jd.inv_bind_mat, matrix);
UnitConverter::dae_matrix_to_mat4_(jd.inv_bind_mat, matrix);
joint_data.push_back(jd);
}

2
source/blender/io/collada/TransformReader.cpp
View File

@ -130,7 +130,7 @@ void TransformReader::dae_scale_to_mat4(COLLADAFW::Transformation *tm, float m[4
void TransformReader::dae_matrix_to_mat4(COLLADAFW::Transformation *tm, float m[4][4])
{
unit_converter->dae_matrix_to_mat4_(m, ((COLLADAFW::Matrix *)tm)->getMatrix());
UnitConverter::dae_matrix_to_mat4_(m, ((COLLADAFW::Matrix *)tm)->getMatrix());
}
void TransformReader::dae_translate_to_v3(COLLADAFW::Transformation *tm, float v[3])

7
source/blender/io/collada/TransformWriter.cpp
View File

@ -47,9 +47,7 @@ void TransformWriter::add_joint_transform(COLLADASW::Node &node,
}
double dmat[4][4];
UnitConverter *converter = new UnitConverter();
converter->mat4_to_dae_double(dmat, local);
delete converter;
UnitConverter::mat4_to_dae_double(dmat, local);
if (export_settings.get_object_transformation_type() == BC_TRANSFORMATION_TYPE_MATRIX) {
node.addMatrix("transform", dmat);
@ -81,9 +79,8 @@ void TransformWriter::add_node_transform_ob(COLLADASW::Node &node,
switch (export_settings.get_object_transformation_type()) {
case BC_TRANSFORMATION_TYPE_MATRIX: {
UnitConverter converter;
double d_obmat[4][4];
converter.mat4_to_dae_double(d_obmat, f_obmat);
UnitConverter::mat4_to_dae_double(d_obmat, f_obmat);
if (limit_precision) {
BCMatrix::sanitize(d_obmat, LIMITTED_PRECISION);