tmaq
/
tornavis
1
0
Fork 0
Code Issues 2 Pull Requests 29 Packages Projects 24 Releases Wiki Activity

Fix assert failures in the dependency graph 

Happens after recent changes in the area.

The asserts were a bit too strict and were against the way how the
ID_RECALC_ALL is handled. So remove them with explanation why things
needs to be silent.
This commit is contained in:
Sergey Sharybin 2022-08-03 09:31:05 +02:00
parent e3913ec6c1
commit d269fb1d72
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/depsgraph/intern/depsgraph_tag.cc
View File

@ -227,7 +227,9 @@ void depsgraph_tag_to_component_opcode(const ID *id,
case ID_RECALC_PROVISION_29:
case ID_RECALC_PROVISION_30:
case ID_RECALC_PROVISION_31:
BLI_assert_msg(0, "Should not happen");
/* Silently ignore.
* The bits might be passed here from ID_RECALC_ALL. This is not a codmistake, but just the
* way how the recalc flags are handled. */
break;
}
}
@ -757,7 +759,10 @@ const char *DEG_update_tag_as_string(IDRecalcFlag flag)
case ID_RECALC_PROVISION_29:
case ID_RECALC_PROVISION_30:
case ID_RECALC_PROVISION_31:
BLI_assert_msg(0, "Should not happen");
/* Silently return nullptr, indicating that there is no string representation.
*
* This is needed due to the way how logging for ID_RECALC_ALL works: it iterates over all
* bits and converts then to string. */
return nullptr;
}
return nullptr;